Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#68 Integrate RDR embeddable figshare content to UCLH research discov… #71

Merged
merged 2 commits into from
Apr 29, 2024
Merged

#68 Integrate RDR embeddable figshare content to UCLH research discov… #71

merged 2 commits into from
Apr 29, 2024

Conversation

lawrencelai
Copy link
Contributor

@lawrencelai lawrencelai commented Apr 24, 2024 •
edited
Loading

Issue ref : #68

I embedded the RDR figshare iframe into the "Detecting misplaced NG tubes" data card.
All synthetic data (synthetic CXR and synthetic EHR CSV) are stored in RDR now instead of the GitHub repo.

Author Checklist
As author of this pull request I confirm:

  • This submission does not include, or link to any sensitive or person identifiable data
  • I have permission from my co-investigators on the project to publish this information
  • I understand that I have the right to add, amend or remove information published about the project

Reviewer Checklist
Reviewers should confirm the following:

  • These changes are limited to the creation of a new folder under /_projects/ and new content within that folder or these changes update one existing project
  • Running bundle exec jekyll serve on their local machine builds the site without any errors
  • The display of the new content appears normal and there are no obviously broken or missing elements on the page
  • The content has been read and checked for offensive material or spam

@lawrencelai
SAFEHR-data#68 Integrate RDR embeddable figshare content to UCLH rese…
d081957 
…arch discovery site (ngtube)

1. Add embeddable figshare iframe (RDR) into uclh_ngtube_s0 project
2. Delete the DICOM images and synthetic csv data file
@uy-rrodriguez uy-rrodriguez requested review from docsteveharris and removed request for tcouch and uy-rrodriguez April 24, 2024 14:33
@uy-rrodriguez
Copy link
Contributor

Changed reviewer to Steve and updated the code that automatically assigned it to Tom or Amanda.
I had to merge those changes into your branch for the PR to be valid.
In the future, I recommend pushing to a project-specific branch, to avoid conflicts with general updates to the base code. Maybe worth updating the guidance.

docsteveharris
docsteveharris approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@docsteveharris docsteveharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving but assume that you've completed the checks that Tom outlined in the pull request template https://github.com/UCLH-Foundry/uclh-research-discovery/blob/main/.github/PULL_REQUEST_TEMPLATE.md?

@docsteveharris
Copy link
Contributor

I'm approving but assume that you've completed the checks that Tom outlined in the pull request template https://github.com/UCLH-Foundry/uclh-research-discovery/blob/main/.github/PULL_REQUEST_TEMPLATE.md?

@lawrencelai if this ☝️is true then please merge, close and delete the branch once done

@lawrencelai
Copy link
Contributor Author

I have added the Author checklist for this pull request.
@uy-rrodriguez Can you help to merge this PR? I have no permission to merge.

@uy-rrodriguez uy-rrodriguez merged commit 795d07f into SAFEHR-data:main Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@docsteveharris docsteveharris docsteveharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lawrencelai @uy-rrodriguez @docsteveharris