Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new synthetic data project for demo use (NGTUBE and CCHIC) #64

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Create a new synthetic data project for demo use (NGTUBE and CCHIC) #64

merged 7 commits into from
Apr 12, 2024

Conversation

lawrencelai
Copy link
Contributor

@lawrencelai lawrencelai commented Apr 11, 2024 •
edited
Loading

This pull request is to create a new synthetic data project(NGTUBE and CCHIC, demo use).

  1. All Attached CSV files were generated by the Turing tool (sqlsynthgen) with the specific vocabulary data set (NGTUBE and CCHIC)
  2. All omop data is randomly generated by predefined man-made rules and outside GAE env.
  3. CSV files will be deleted and relinked to RDR once RDR access is ready.

@lawrencelai
rollback and delete the "demo" project status
1826519 
change ngtube and cchic project status to "completed"
@uy-rrodriguez uy-rrodriguez requested review from docsteveharris and removed request for acholyn April 11, 2024 16:37
@uy-rrodriguez
Copy link
Contributor

Added @docsteveharris to review the contents.
Should we also include Sean to validate that no data is exposed?

uy-rrodriguez
uy-rrodriguez suggested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@uy-rrodriguez uy-rrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR for project data should not make changes to the base code. Please remove this. You can set the status as "in progress"

@lawrencelai
Copy link
Contributor Author

About the base code changing, I rolled back already after my first commit so no base code has been updated now.
The status has been updated to "on-going".

docsteveharris
docsteveharris reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@docsteveharris docsteveharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Added some detail to the summaries

@docsteveharris docsteveharris merged commit e08e514 into SAFEHR-data:main Apr 12, 2024
1 check passed
@lawrencelai
Copy link
Contributor Author

Thanks Steve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uy-rrodriguez uy-rrodriguez uy-rrodriguez requested changes

@docsteveharris docsteveharris docsteveharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lawrencelai @uy-rrodriguez @docsteveharris