Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker files and updated Gemfile for local dev #62

Closed
wants to merge 1 commit into from

Conversation

uy-rrodriguez
Copy link
Contributor

Added Docker configuration files to run Jekyll site using Docker.
Updated Gemfile because some libraries didn't work in the Alpine image.

@docsteveharris docsteveharris requested a review from tcouch April 11, 2024 18:08
@docsteveharris
Copy link
Contributor

@tcouch would you be able to review? I don't have the knowledge to comment. Sorry - I know you're not on this any more

@uy-rrodriguez
Copy link
Contributor Author

I need to review this PR. It's internal work. I've been testing a few updates on a different fork to not impact this published website, but will merge all updates here in time, and check whether this PR is still valid.

@tcouch
Copy link
Collaborator

tcouch commented Apr 17, 2024

Sorry @docsteveharris, @uy-rrodriguez I only just saw the notification about this. Do you still want me to review? Happy to do so.

@uy-rrodriguez
Copy link
Contributor Author

Sorry @docsteveharris, @uy-rrodriguez I only just saw the notification about this. Do you still want me to review? Happy to do so.

Let me see if the PR is still needed first and I'll come back to you :)

@uy-rrodriguez
Copy link
Contributor Author

Confirmed, this PR should have been closed a while ago.

@uy-rrodriguez uy-rrodriguez deleted the feature/docker-files branch April 24, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants