Proposal to run Jekyllify right before the website is built #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Jekyllified projects are exported as an artifact
- Also renamed folder to use capitals for acronym
Status indicator
Closed
|
Changes proposed where applied in #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of running Jekyllify right before the page build seems to be working.
Sample published here:
https://uy-rrodriguez.github.io/uclh-research-discovery/
In essence, an artifact is exported with the contents of _projects after Jekyllify, which is then imported before generating the website.
The changes are never committed. You can see, for e.g., that the test project stays as initially uploaded:
https://github.com/uy-rrodriguez/uclh-research-discovery/tree/main/_projects/UCLH_mock_data
The files with the generated front-matter can be seen in the artifact, accessible from the action page. I set it to expire after a day, it's useful for debugging but I'm not sure we need it longer.
Minor changes
titlecaseinstead ofstring.title(), to support acronyms and ignore connectors (like "and", "of"). Acronyms need to appear in capitals in the project folder (e.g. "UCLH"). Not sure this is very useful since users can provide atitle.txt.check_projects.pyimported fromjekyllify.pyto reuse the logic that checks for files.