Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup script changes and misc bug fixes #64

Merged
merged 17 commits into from
Oct 9, 2024

Conversation

jeremyestein
Copy link
Collaborator

@jeremyestein jeremyestein commented Oct 3, 2024

Setup script changes for validation (including fixing #25 )

Design doc update.

Miscellaneous fixes that were needed to process the HL7 dump file during validation. Mostly parsing error handling.

Copy link

github-actions bot commented Oct 3, 2024

PR checklist

Default guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)

  • From the UCLH data science desktop, a validation run has been set off
  • load times
    in UCL teams has been populated with the run information
  • During the run, glowroot has been checked for any queries which are taking a substantial proportion of the
    total processing time. This can be useful to identify indexes that are required.
  • After the run, look for any unexpected errors in the etl_per_message_logging table, the error_search.sql file
    on the shared drive can be used for this \\sharefs6\UCLH6\EMAP\Shared\EmapSqlScripts\devops\error_search.sql.
    Create an issue if you find an unexpected exception and is not related to the changes you've made, otherwise
    fix them!
  • After the run, populate the end time in
    load times
  • Let Aasiyah know about the completed validation and give her information on the changes and where to start
    with the validation
  • Check validation report and give any feedback to Aasiyah if there are any changes needed on her side,
    iterate on getting the validation to match at least 99% (validation and emap code).

Base automatically changed from jeremy/hf-data-misc to sk/waveform-dev October 7, 2024 12:40
@jeremyestein jeremyestein marked this pull request as ready for review October 7, 2024 16:30
Copy link
Member

@t-young31 t-young31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not looked at the Java but the Python changes LGTM 🚀

Comment on lines 194 to 203
use_hoover = ("hoover" in self.global_config["repositories"]) and (not self.args.use_only_hl7_reader)
use_hoover = ("hoover" in self.global_config["repositories"]) and self.args.use_hoover
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this should be

if self.args.use_hoover and "hoover" not in self.global_config["repositories"]:
    raise ValueError("hoover missing from repositories in global config")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, that avoids failing silently if the user asked for hoover

Comment on lines 201 to 202
"""Time elapsed since the runner started"""
return timedelta(seconds=time() - self.start_time)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

Probably best to change the type of start_time to datetime.datetime then

Suggested change
"""Time elapsed since the runner started"""
return timedelta(seconds=time() - self.start_time)
"""Time elapsed since the runner started"""
assert self.start_time is not None
return datetime.now() - self.start_time

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since start_time isn't needed outside that method I've turned it into a local. And it should be a monotonic clock to ignore system time jumps.

@jeremyestein jeremyestein merged commit 4d87fac into sk/waveform-dev Oct 9, 2024
7 checks passed
@jeremyestein jeremyestein deleted the jeremy/hf-data-setup branch October 9, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants