Address some review comments

SAFEHR-data · Oct 23, 2024 · c635859 · c635859
1 parent 4d87fac
commit c635859
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...java/uk/ac/ucl/rits/inform/datasinks/emapstar/controllers/VisitObservationController.java b/...java/uk/ac/ucl/rits/inform/datasinks/emapstar/controllers/VisitObservationController.java
@@ -130,12 +130,11 @@ public void processFlowsheet(Flowsheet msg, HospitalVisit visit, Instant storedF
      * @return new or existing VisitObservationType
      */
     public VisitObservationType getOrCreateFromWaveform(WaveformMessage msg, Instant storedFrom) {
-//        RowState<VisitObservationType, VisitObservationTypeAudit> observationType = getOrCreateObservationTypeState(
         VisitObservationType observationType = cache.getOrCreatePersistedObservationType(
                 msg.getSourceStreamId(), msg.getSourceStreamId(), "waveform", msg.getObservationTime(), storedFrom);
         observationType.setName(msg.getMappedStreamDescription());
         observationType.setIsRealTime(true);
-        // XXX: what about updates if the description changes over time?
+        // Might want to consider updating/auditing if the name/description changes. See Issue #71
         return observationType;
     }
 

diff --git a/...tar/emap-star/src/main/java/uk/ac/ucl/rits/inform/informdb/visit_recordings/Waveform.java b/...tar/emap-star/src/main/java/uk/ac/ucl/rits/inform/informdb/visit_recordings/Waveform.java
@@ -79,6 +79,9 @@ public class Waveform extends TemporalCore<Waveform, WaveformAudit> {
     @Column(columnDefinition = "timestamp with time zone", nullable = false)
     private Instant observationDatetime;
 
+    /**
+     * \brief Sampling rate of this data series in Hz.
+     */
     @Column(nullable = false)
     private long samplingRate;