Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1387

Closed
wants to merge 12 commits into from
2 changes: 1 addition & 1 deletion ZelBack/src/services/appsService.js
Original file line number Diff line number Diff line change
Expand Up @@ -5542,7 +5542,7 @@ function verifyRestrictionCorrectnessOfApp(appSpecifications, height) {
}
// check wheter shared Folder is not root
if (appComponent.containerData.length < 2) {
throw new Error(`Flux App container data folder not specified in in ${appComponent.name}. If no data folder is whished, use /tmp`);
throw new Error(`Flux App container data folder not specified in ${appComponent.name}. If no data folder is whished, use /tmp`);
}

if (appSpecifications.version >= 7) {
Expand Down
6 changes: 5 additions & 1 deletion helpers/blockedrepositories.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,9 @@
"1060dc623fcfbca15149ab3d776cb90fd4620ad0a6a91bad7ff125e11708b484",
"6b6a47a2b0bb9f9405e4768c446dedd781f0b0e51f65c310d2095085b8e70e80",
"dfdadb3858282fdf2d89fe21dc1909406d6f2f617f2bfa2e6ad1c9b7908cd878",
"4a5828ec4dddfacbc3367723a21c7a3646f57a63e569ae372047333d97779bed"
"4a5828ec4dddfacbc3367723a21c7a3646f57a63e569ae372047333d97779bed",
"de426c69eed13f8bf9513b91a0e2506af70290d46fc6ccaa2324012c75dcae8b",
"6718b5e140301c815ef2f8f0fec1a6ad8fa853f68b85a69828cfaa8f75470910",
"c806276870c9a14fc474b7ab228e0c2e919fdebde56f85151865157b7a24f758",
"30b142d93719d54b9ceb9a860552397770314aa93f892be3214ffc251fd67883"
]
6 changes: 4 additions & 2 deletions helpers/hashes.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
[
"7cbfce1dd56f4e89f8c7a25858892ead",
"422fb5c5ee75b4f0739ace348d6e7b82",
"459a0f8ee02e370b4a30c130dd3156f8",
"98a0db6d9ca3a096606d5a95a8d2aa89",
"a267c50970dcdc48985c9c1247f37d74"
"a267c50970dcdc48985c9c1247f37d74",
"cb1c497ca97d8ffcb9baae41fa0bfe7e",
"ba0ac54e74606a381bff24b019f9a255",
"fd5a4c764f09562a2fcbe573ff8077a3"
]
2 changes: 1 addition & 1 deletion tests/unit/benchmarkService.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ describe('benchmarkService tests', () => {

describe.skip('signFluxTransactionPost tests', () => {
// TODO: These tests are going to be altered when we're switching all requests from streams to body.parse.
// As they are right now - it's almost impossible to test without actually starting the deamon or without using hacky workarounds
// As they are right now - it's almost impossible to test without actually starting the daemon or without using hacky workarounds

beforeEach(async () => {
sinon.stub(fs, 'stat').resolves(true);
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/fluxCommunication.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1340,7 +1340,7 @@ describe('fluxCommunication tests', () => {
sinon.restore();
});

it('should send warning if deamon is not synced', async () => {
it('should send warning if daemon is not synced', async () => {
daemonServiceStub.returns({
data: {
synced: false,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/fluxCommunicationMessagesSender.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2131,7 +2131,7 @@ describe('fluxCommunicationMessagesSender tests', () => {
sinon.assert.notCalled(websocketOut.send);
});

it('should throw an error if the message.singature is not a string', async () => {
it('should throw an error if the message.signature is not a string', async () => {
const temporaryAppMessage = { // specification of temp message, these are not verified in this function
type: 'fluxapp',
version: 3,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/socketIoServer.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('FluxSocketServer tests', () => {
expect(ioServer.io.opts.transports).to.deep.equal(['websocket']);
expect(ioServer.io.opts.cors).to.deep.equal({ origin: '/test', methods: ['GET'] });

// this would be a lot easier to test if the error event called the handler direclty
// this would be a lot easier to test if the error event called the handler directly
errorHandlers[0]();
expect(logged).to.equal(true);
});
Expand Down