Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to collection sampling methods #717

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mihow
Copy link
Collaborator

@mihow mihow commented Feb 6, 2025

Summary

Screenshots

If applicable, add screenshots to help explain this PR (ex. Before and after for UI changes).

image

image

Checklist

  • I have tested these changes appropriately.
  • I have added and/or modified relevant tests.
  • I updated relevant documentation or comments.
  • I have verified that this PR follows the project's coding standards.
  • Any dependent changes have already been merged to main.

Copy link

sentry-io bot commented Feb 6, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: ami/main/models.py

Function Unhandled Issue
sample_captures_by_interval ValueError: Queryset must be provided, and it should be limited to a Project. ...
Event Count: 6

Did you find this useful? React with a 👍 or 👎

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for ami-dev ready!

Name Link
🔨 Latest commit 4e0aa2d
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/67a442d3174ebf0008ad64a2
😎 Deploy Preview https://deploy-preview-717--ami-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72
Accessibility: 89
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow mihow added bug Something isn't working enhancement New feature or request labels Feb 6, 2025
@mihow mihow self-assigned this Feb 6, 2025
@mihow
Copy link
Collaborator Author

mihow commented Feb 6, 2025

@annavik I had to fix a couple things for the labeling project to create their collections. I added a date field to the collections form in the simplest way possible. But I bet we can add a real date picker from the Nova components?? Also a checkbox for "shuffle", and make the sampling method a hidden field. I'll add a ticket for that unless you beat me to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error when populating collections
1 participant