Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

700 fix the list of online processing services per project #705

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vanessavmac
Copy link
Collaborator

Summary

Fix bugs associated with filtering processing services by project.

List of Changes

  • Fixed the value of "Processing Services Online" on the pipeline overview page. Previous, the count included all processing services of a pipeline across all projects. Filter to only include the activate project.
  • Ensure images can only be processed by processing services in the active project.

Related Issues

Closes #700

@vanessavmac vanessavmac requested a review from mihow January 28, 2025 05:56
@vanessavmac vanessavmac self-assigned this Jan 28, 2025
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for ami-dev canceled.

Name Link
🔨 Latest commit cb69c66
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/67988543dbb42200083a5532

@vanessavmac
Copy link
Collaborator Author

vanessavmac commented Jan 28, 2025

@mihow From #700:

Also "Pipelines registered" includes all pipelines under that processing service, not filtered by current project.

285f8ae addresses this bug, but just to make sure I understood correctly: When a user adds pipelines by clicking the "Register Pipelines" button, it automatically adds those pipelines to that project. But if the pipeline is removed from the project (i.e. through Django admin) the user should not be able to see this pipeline as "registered" or in the ProcessingServiceDetails for this project? Not sure how in a real-life use case without the admin this would occur

I also updated the ProcessingServiceDetails so that only pipelines added to the project are visible

@vanessavmac vanessavmac marked this pull request as ready for review January 28, 2025 07:08
@vanessavmac
Copy link
Collaborator Author

vanessavmac commented Jan 28, 2025

@mihow Backend tests failed but I think it's a cache issue? cb69c66 should fix the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the list of online processing services per-project
1 participant