-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present latest job status in collections table and update populate button logic #657
Conversation
✅ Deploy Preview for ami-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks a lot for adding this! I didn't had time to revisit this PR today, but hope to do it soon. |
Awesome thanks! Do you think we can merge the work you already did for the collections view first? And then implement the deployments <-> jobs features in a follow-up? @vanessavmac is adding a new button similar to the Populate button in her PR #632 but the new button doesn't update based on the response status (if it fails it stays gray forever). I think we can use the code in this PR as an example. |
Yes! I have synced this PR with main now, pushed some remaining updates related to jobs and collections and also updated the PR description. Let's merge this and handle remaining views in a follow up PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! This is a great improvement to our collection syncing, and a good template for action buttons in the project entities table, thank you!
Summary
In this PR we start look into the task "Use job status to update UI for collections, captures & deployments" (see #650). To begin with, we include some frontend improvements related to jobs and collections (see screenshots for details). Also @mihow is adding some backend updates related to deployments and jobs as part of this PR. We will include frontend changes for remaining views in a follow up PR.
Screenshots