Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present latest job status in collections table and update populate button logic #657

Merged
merged 12 commits into from
Jan 17, 2025

Conversation

annavik
Copy link
Member

@annavik annavik commented Dec 16, 2024

Summary

In this PR we start look into the task "Use job status to update UI for collections, captures & deployments" (see #650). To begin with, we include some frontend improvements related to jobs and collections (see screenshots for details). Also @mihow is adding some backend updates related to deployments and jobs as part of this PR. We will include frontend changes for remaining views in a follow up PR.

Screenshots

Screenshot 2025-01-16 at 15 56 23 Screenshot 2025-01-16 at 15 51 15

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for ami-dev ready!

Name Link
🔨 Latest commit e6b64ab
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/6789a82e215b7d0008ff1ad5
😎 Deploy Preview https://deploy-preview-657--ami-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73
Accessibility: 89
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@annavik
Copy link
Member Author

annavik commented Dec 16, 2024

Short summary after first session working on this:

✅ We have the backend info we need to link to a filtered job view from collections and captures. Frontend app is up to date here now.

⏳ We need to include a list of jobs in the deployments API response in order to do the same here.

⏳ If we can include job type in the API responses, we can adjust status labels to better reflect what is going on. For example show "Populating" instead of "Running".

🤔 The list of jobs that is included with the collections response has status labels that are not up to date (they are not the same as the ones I see in the full job table). Some cache or rewrite problem? I'm using local backend.

Screenshot:

Screenshot 2024-12-16 at 15 33 28

@mihow
Copy link
Collaborator

mihow commented Jan 15, 2025

@annavik I added the jobs list to the Deployments API and added the job_type data to all job status objects. I think I will have fixed the job status caching issue in #635

image

@annavik
Copy link
Member Author

annavik commented Jan 15, 2025

Thanks a lot for adding this! I didn't had time to revisit this PR today, but hope to do it soon.

@mihow
Copy link
Collaborator

mihow commented Jan 15, 2025

Awesome thanks! Do you think we can merge the work you already did for the collections view first? And then implement the deployments <-> jobs features in a follow-up? @vanessavmac is adding a new button similar to the Populate button in her PR #632 but the new button doesn't update based on the response status (if it fails it stays gray forever). I think we can use the code in this PR as an example.

@annavik
Copy link
Member Author

annavik commented Jan 16, 2025

Awesome thanks! Do you think we can merge the work you already did for the collections view first? And then implement the deployments <-> jobs features in a follow-up? @vanessavmac is adding a new button similar to the Populate button in her PR #632 but the new button doesn't update based on the response status (if it fails it stays gray forever). I think we can use the code in this PR as an example.

Yes! I have synced this PR with main now, pushed some remaining updates related to jobs and collections and also updated the PR description.

Let's merge this and handle remaining views in a follow up PR!

@annavik annavik changed the title [Draft] Present job info Present latest job status in collections table and update populate button logic Jan 16, 2025
@mihow mihow marked this pull request as ready for review January 17, 2025 00:43
Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! This is a great improvement to our collection syncing, and a good template for action buttons in the project entities table, thank you!

@mihow mihow merged commit b08ff18 into main Jan 17, 2025
6 checks passed
@mihow mihow deleted the feat/present-job-info branch January 17, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants