Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user data form bug #642

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix user data form bug #642

merged 1 commit into from
Dec 3, 2024

Conversation

annavik
Copy link
Member

@annavik annavik commented Dec 2, 2024

The save button was not triggering form submit when editing user info. The problem was the submit button was actually rendered outside the HTML form tag (not sure when this happened?). In this PR we fix this!

The problematic button:

Screenshot 2024-12-02 at 16 50 43

@annavik annavik requested a review from mihow December 2, 2024 15:52
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for ami-dev ready!

Name Link
🔨 Latest commit ca65807
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/674dd7c12e144800081d9e73
😎 Deploy Preview https://deploy-preview-642--ami-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73
Accessibility: 89
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this but thought is was a fluke. Thanks for fixing! What kind of test do you think can catch this type of issue / regression?

@annavik
Copy link
Member Author

annavik commented Dec 2, 2024

I would probably suggest manual regression testing here as a first step (define a regression test plan and make updating user info part of this). When regression testning is part of our release process, I think a good next step could be to look into tools for automation. Cypress, Selenium and Pupeteer are examples of some tools that can be used to simulate browser interactions.

What are your thoughts?

@annavik
Copy link
Member Author

annavik commented Dec 3, 2024

I will merge this now, but let's talk more about regression tests if you think it's a good idea! :) I think it could make sense to have this part of our process once we start to do a bit more controlled releases?

@annavik annavik merged commit 2c2b9d6 into main Dec 3, 2024
6 checks passed
@annavik annavik deleted the fix/user-data-form-bug branch December 3, 2024 09:05
@annavik annavik mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants