Require open source license for project creation #553
+115
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ami-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annavik
commented
Sep 4, 2024
| @@ -13,5 +13,9 @@ export const convertToServerFormData = (fieldValues: any) => { | |||
| data.append('image', '') | |||
| } | |||
|
|
|||
| if (fieldValues.openSource) { | |||
| data.append('license', 'open-source') | |||
There was a problem hiding this comment.
Let's tweak this, if backend prefers the license to be passed in a different way.
|
Thanks @annavik! I am going to think about the backend part. I think we should check for this acceptance before every image sync or processing job. In-case the option gets unchecked, and also for existing projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/RolnickLab/ami-admin/issues/21
In this PR we block project creation client side, unless open source license has been selected. We still show the other option, but disabled.
Left to do on the backend side
Screenshot