Implement handling of cookie consent and related logic #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annavik
changed the title
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annavik
commented
Aug 27, 2024
|
|
||
| const GTM_ID = 'G-EX26RXX0YT' | ||
|
|
||
| export const Analytics = () => { |
There was a problem hiding this comment.
In #351 we said to use a React lib for this, however the most popular one for Google Tag Manager did not work out of the box and after a closer look it seemed pretty outdated.
I suggest we use this custom implementation, at least until we have more advanced analytics. It's pretty much same as before, except we conditionally load the scripts depending on cookie consent status.
mihow
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #350, #351 and #541
Summary of cookie dialog logic
Cookie categories
This is how we currently categorize the app's stored items.
Comments
We are awaiting response from Mila Legal on approval on both copy and logic for cookie handling. The current implementation is based on previous experiences and other sites from Mila.
Screenshots