Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small UI bugs after feedback #401

Merged
merged 12 commits into from
Jun 10, 2024
Merged

Fix small UI bugs after feedback #401

merged 12 commits into from
Jun 10, 2024

Conversation

annavik
Copy link
Member

@annavik annavik commented Jun 6, 2024

Fixing some smaller problems that showed up during feedback sessions:

  • When editing user info, the email field is called “Name” as well as the name field
  • Make name a required field?
  • Highlight required fields with *
  • Show "10+" in the slideshow count if there are more than 10, to help troubleshoot mismatched counts
  • Show seconds in the timeline component
  • Show timestamps all the time in timeline component (not just on hover)
  • Show that saving was successful in user info form
  • Do not show "Sign up" if user is logged in (captured in Sign up button should not be visible when logged in #385)
  • Fix issue with "not available" label showing up as a number in session details

@annavik annavik requested a review from mihow June 6, 2024 13:24
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit cbf51bc
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/6666ecbd3e121f000805461f
😎 Deploy Preview https://deploy-preview-401--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit cbf51bc
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/6666ecbc62dd9d000835565f
😎 Deploy Preview https://deploy-preview-401--ami-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow
Copy link
Collaborator

mihow commented Jun 8, 2024

This is awesome, thank you for finding all of these comments. I have heard them from multiple people. One thing I noticed right away is that the localized AM/PM time breaks to a new line in the timeline view, even with a wide window size. But there is plenty of room on the left side.

image

@annavik annavik self-assigned this Jun 10, 2024
@annavik
Copy link
Member Author

annavik commented Jun 10, 2024

This is awesome, thank you for finding all of these comments. I have heard them from multiple people. One thing I noticed right away is that the localized AM/PM time breaks to a new line in the timeline view, even with a wide window size. But there is plenty of room on the left side.

image

Oh good catch, I missed it because of my locale. Fixed!

Skärmavbild 2024-06-10 kl  14 05 07

Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the 10+, and thanks for the other details!

@mihow mihow merged commit 1b4a707 into main Jun 10, 2024
6 checks passed
@mihow mihow deleted the fix/small-ui-bugs branch June 10, 2024 13:54
@annavik annavik added this to the Internal Beta V2 Release milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants