Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session details navigation #347

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Fix session details navigation #347

merged 3 commits into from
Feb 13, 2024

Conversation

annavik
Copy link
Member

@annavik annavik commented Feb 10, 2024

Fixes #329

Also including two small related fixes:

  • Do not fetch capture details until capture id is set (I noticed we did one "capture/undefined" fetch on session details load)
  • Fix broken session link in occurrence table

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit f9c7e7c
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/65c744249ae5240008c9cd00
😎 Deploy Preview https://deploy-preview-347--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit f9c7e7c
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/65c74424871b2000088c1e6d
😎 Deploy Preview https://deploy-preview-347--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@annavik annavik requested a review from mihow February 10, 2024 10:07
Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mihow mihow merged commit 37f6e42 into main Feb 13, 2024
6 checks passed
@mihow mihow deleted the fix/session-details-navigation branch February 13, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back button broken when navigating from occurrences table to session detail
2 participants