Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show beta info in header #340

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Show beta info in header #340

merged 6 commits into from
Feb 1, 2024

Conversation

annavik
Copy link
Member

@annavik annavik commented Jan 31, 2024

Fixes #336

Was it something like this you had in mind @mihow ?

Screenshot 2024-01-31 at 21 36 23 Screenshot 2024-01-31 at 21 36 28

Comments:

  • Do we want to show some more info on hover? Feel free to tweak the copy!
  • Version I pick from package.json (FE project), is this how we should define the the "app version"?
  • Got kind of crowded in header on small screens, I skipped the info pages on small screens for now.

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 6b60e85
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/65bac106ddfa240008154cb0
😎 Deploy Preview https://deploy-preview-340--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit 6b60e85
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/65bac106755e7b00085d192b
😎 Deploy Preview https://deploy-preview-340--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow
Copy link
Collaborator

mihow commented Jan 31, 2024

Amazing, thank you! Perhaps for the tooltip text: "All data is considered test data and may change or be deleted at any time. Use with caution."

@annavik
Copy link
Member Author

annavik commented Jan 31, 2024

Amazing, thank you! Perhaps for the tooltip text: "All data is considered test data and may change or be deleted at any time. Use with caution."

Yes! Copy is updated and version changed to latest commit hash:

Screenshot 2024-01-31 at 22 27 54

@mihow
Copy link
Collaborator

mihow commented Jan 31, 2024

I think BETA looks better as in your first! We can save Preview Release when we make a release!
And a slight tweak on copy.
"All data is considered test data and may be changed or deleted at any time. Use with caution."

I can make these changes too if you are done for the night!

@annavik
Copy link
Member Author

annavik commented Jan 31, 2024

All data is considered test data and may be changed or deleted at any time. Use with caution.

No worries, copy tweaked! :)

import { defineConfig } from 'vite'
import eslint from 'vite-plugin-eslint'
import svgr from 'vite-plugin-svgr'
import viteTsconfigPaths from 'vite-tsconfig-paths'

const commitHash = childProcees
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool!

@mihow mihow merged commit 1b065ff into main Feb 1, 2024
6 checks passed
@mihow mihow deleted the beta-info branch February 8, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banner indicating beta/testing status of app
2 participants