Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally enable Sentry #332

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conditionally enable Sentry #332

merged 1 commit into from
Dec 5, 2023

Conversation

annavik
Copy link
Member

@annavik annavik commented Dec 5, 2023

@annavik annavik requested a review from mihow December 5, 2023 21:34
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit a7999ca
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/656f97463e755e0008f41be7
😎 Deploy Preview https://deploy-preview-332--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 82
Accessibility: 100
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit a7999ca
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/656f974600a10b0008921f06
😎 Deploy Preview https://deploy-preview-332--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mihow
mihow reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify NODE_ENV when building in Netlify?

mihow
mihow approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it!
image

@mihow mihow merged commit 1e97b23 into main Dec 5, 2023
5 checks passed
@mihow mihow deleted the web-ui-conditionally-enable-sentry branch February 8, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihow mihow mihow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annavik @mihow