-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control for marking captures as starred #326
Conversation
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@annavik I added an unstar endpoint and attempted to implement it in the UI. I also tried to use a tooltip instead of a label. But looks like label is required on a Button, so maybe there is a better way to do that for accessibility? Let me know how I did. Also what do you think about moving the heart to the main controls row, before the user clicks expand? |
Looks great! We have a separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it. Also the loading indicator works great, thank you.
Not starred capture:
![Screenshot 2023-11-27 at 23 25 14](https://private-user-images.githubusercontent.com/11680517/286040679-27d072ed-a0d0-4773-a9e9-c17841089dcd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDA5OTAsIm5iZiI6MTczODkwMDY5MCwicGF0aCI6Ii8xMTY4MDUxNy8yODYwNDA2NzktMjdkMDcyZWQtYTBkMC00NzczLWE5ZTktYzE3ODQxMDg5ZGNkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDAzNTgxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJlY2ZjYWVlYzM3YWIzZTg2MTJkNWRkNDA4MDIxNjcyOWIxOTM2ZTVjNjNjMmEwODg3ZjVlYzgxYjQ2OWZhNGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Kgr-wj7H3AQq30eOhl3GPqEpsv2hP7pQeooQnF3e74Q)
Starred capture (when possible to unmark as starred, we can have this clickable):
![Screenshot 2023-11-27 at 23 25 25](https://private-user-images.githubusercontent.com/11680517/286040655-13e4d993-2074-4044-8627-2e9a9d153a8a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDA5OTAsIm5iZiI6MTczODkwMDY5MCwicGF0aCI6Ii8xMTY4MDUxNy8yODYwNDA2NTUtMTNlNGQ5OTMtMjA3NC00MDQ0LTg2MjctMmU5YTlkMTUzYThhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDAzNTgxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxNjY3YzE3Y2U0ZGZiMDI4ZjI0MzEyMzdhOGZkNzBhNzY3ZWQzNTdkMzRlMzE2ZjVlNTI5YmYwZjI4NWUxZjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.R7ligMRqCVj9ZDF8qHhwuBTG2ystCg7ncLZ8W8yCtWw)