Merge pull request #216 from Roger13579/fix/create-order-plan

fix: calculate total price error and float handling
Roger13579 · Jun 13, 2024 · 633e616 · 633e616
2 parents 3b42406 + 7f6e1dc
commit 633e616
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/dto/order/createOrderDto.ts b/src/dto/order/createOrderDto.ts
@@ -77,6 +77,7 @@ export class CreateOrderDto {
     this._items = Object.values(groupBy(items, 'productId')).map((group) => ({
       productId: group[0].productId,
       amount: sumBy(group, 'amount'),
+      plan: group[0].plan,
     }));
     this.paymentMethod = paymentMethod;
     this.paymentStatus = PaymentStatus.pending;

diff --git a/src/service/orderService.ts b/src/service/orderService.ts
@@ -336,8 +336,12 @@ export class OrderService {
     const subTotal = sumBy(
       products,
       ({ price, amount, plan }) =>
-        price * amount * (plan ? plan.headCount * plan.discount : 1),
+        Math.round(
+          price * amount * (plan ? plan.headCount * plan.discount : 1) * 100,
+        ) / 100,
     );
+    logger.info('totalPrice = ' + totalPrice);
+    logger.info('subTotal = ' + subTotal);
     return totalPrice === subTotal;
   };