Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Adjust Button and FormTextInput to prevent layout issues when text size is increased in settings #6110

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jan 24, 2025

Proposed changes

When the text size is increased in settings (Android and iOS), the layout of the Button and FormTextInput breaks, cutting off the text in the input or not displaying the full button title. This issue occurred because the components had a fixed height. This PR replaces the fixed height with padding to resolve the problem.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-168

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title fix: removed fixed height on Button and FormTextInput fix(a11y): Adjust Button and FormTextInput to prevent layout issues when text size is increased in settings Jan 27, 2025
@OtavioStasiak OtavioStasiak marked this pull request as ready for review January 27, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant