Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist message with already cached file #6093

Closed

Conversation

Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Jan 13, 2025

Proposed changes

When we send the same images in different messages, only the image in the first message will open in the preview, not the ones in the rest. For example, if we send images one and two across three messages, we can tap and open the preview for the image in the first message, but not for the images in the second and third messages. If we send only one image multiple times, this issue occurs too

Issue(s)

N/A

How to test or reproduce

URL: https://********.rocket.chat/api/v1/chat.postMessage
Method: POST
Header: {
     'X-Auth-Token': '**********',
     'X-User-Id': '**********'
}
body: {
  "roomId": "",
  "attachments": [
    {
      "image_url": "https://i.pinimg.com/474x/c4/23/63/c423639b72feb5c93a14144fb50008c3.jpg" //or any random image url
    },
    {
      "image_url": "https://i.pinimg.com/474x/fc/98/6e/fc986eb80193639da37bf34cc5f6ef57.jpg" //or any random image url
    }
  ]
}

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak
Copy link
Contributor

Hey Rohit, thank you for your contribution!
Could you please open this PR pointing to the develop branch? I was able to reproduce the issue on the develop branch.

gif rohit issue

@Rohit3523
Copy link
Contributor Author

Could you please open this PR pointing to the develop branch? I was able to reproduce the issue on the develop branch.

Doing it :)

@Rohit3523 Rohit3523 changed the base branch from feat.multiple-files-render to develop January 14, 2025 17:03
@Rohit3523 Rohit3523 changed the title feat: persist message with already cached file fix: persist message with already cached file Jan 14, 2025
@Rohit3523 Rohit3523 marked this pull request as draft January 14, 2025 17:10
@Rohit3523 Rohit3523 closed this Jan 14, 2025
@Rohit3523
Copy link
Contributor Author

I am closing this PR because I used feat.multiple-files-render as the base branch when creating it. Merging this PR into develop would include changes from feat.multiple-files-render as well. To avoid this, I have created a new PR (#6094) with develop as the base branch to ensure only the relevant changes are merged.

Thank you for understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants