fix: optional methods in video conf providers not being handled correctly #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pierre Lehnen <[email protected]>
pierre-lehnen-rc
approved these changes
Jul 24, 2024
d-gubert
added a commit
that referenced
this pull request
Jul 29, 2024
…ctly (#785) Co-authored-by: Pierre Lehnen <[email protected]>
This was referenced Jul 29, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
Similarly to how the
checkPremethods work on the listener manager, we have optional methods in video conf providers that should not block execution if they are not implementedWhy? 🤔
Links 🌎
PS 👀