Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ILivechatCreator createAndReturnVisitor method #771

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Jun 25, 2024

What?

This pull request is related to the changes introduced in Rocket.Chat PR #32620 and Apps.WhatsApp PR #72.

The modifications in this PR update the createVisitor and doCreateVisitor functions to align with the new expected behavior. These functions will now return the complete records of the created entities, rather than just their IDs.

Links

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2024

CLA assistant check
All committers have signed the CLA.

@debdutdeb
Copy link
Member

isn't this breaking change?

@ricardogarim ricardogarim marked this pull request as ready for review June 25, 2024 12:07
@ricardogarim
Copy link
Contributor Author

isn't this breaking change?

I just modified the methods to keep the existing one and added a new method called createAndReturnVisitor.

@ggazzo ggazzo changed the title refactor: change livechat creation related signatures feat: ILivechatCreator createAndReturnVisitor method Jun 25, 2024
@ggazzo ggazzo merged commit ede11e4 into alpha Jun 25, 2024
8 checks passed
@ggazzo ggazzo deleted the refactor/create-visitor-signature branch June 25, 2024 21:18
d-gubert added a commit that referenced this pull request Jun 26, 2024
@d-gubert d-gubert restored the refactor/create-visitor-signature branch June 26, 2024 18:55
ggazzo added a commit that referenced this pull request Jul 12, 2024
@d-gubert d-gubert mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants