Improve incoming message handling on both Node and Deno #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-gubert
commented
Jan 12, 2024
|
|
||
| let messageBuffer: string[] = []; | ||
|
|
||
| this.deno.stdout.on('data', async (chunk: Buffer) => { |
There was a problem hiding this comment.
I had to move this out of parseOutput because I needed the messageBuffer to live outside the scope of the callback.
There is likely a better way to do this, but it can be left to another time maybe
tapiarafael
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
Both ends of the socket now can receive multiple messages or incomplete messages and will handle this appropriately
Why? 🤔
Links 🌎
PS 👀