Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fix ] Selecting Same Workspace Again Gives Notification About Workspace is Changed #68

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

Sumitwarrior7
Copy link
Contributor

Issue(s)

Closes : #66

Now Notification will be sent only if workspace is changed

Reference:

Screencast.from.04-03-24.05.10.24.PM.IST.webm

@Sumitwarrior7
Copy link
Contributor Author

@Nabhag8848 bhiaya
If you have any issues, please tell me

@Nabhag8848 Nabhag8848 self-requested a review March 5, 2024 06:08
Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Sumitwarrior7 🚀, As this PR is small would you like to work on #41, it has been open since long and merge both PRs, particularly merge this branch to PR for #41 ?

@Nabhag8848 Nabhag8848 changed the title [Fix]: Notification bug fixed [ Fix ] Selecting Same Workspace Again Gives Notification About Workspace is Changed Mar 5, 2024
@Sumitwarrior7
Copy link
Contributor Author

ok @Nabhag8848 bhaiya
I

LGTM @Sumitwarrior7 🚀, As this PR is small would you like to work on #41, it has been open since long and merge both PRs, particularly merge this branch to PR for #41 ?

ok @Nabhag8848 bhaiya

@Spiral-Memory Spiral-Memory mentioned this pull request Mar 6, 2024
4 tasks
@Spiral-Memory
Copy link
Contributor

Sorry, @Nabhag8848 , @Sumitwarrior7 . I mistakenly mentioned my draft PR here. That was with respect to Issue 69

@Nabhag8848
Copy link
Collaborator

Nabhag8848 commented Mar 12, 2024

Hey @Sumitwarrior7 were you able to know, why comment multiline Input bug exists ? let us know if you need any help in understanding the working of code.

@Sumitwarrior7
Copy link
Contributor Author

hello @Nabhag8848 bhaiya
i am quite busy this week, so not able to work on the issue

but i will start solving it on monday

@Nabhag8848
Copy link
Collaborator

Hey @Sumitwarrior7 were you able to know, why comment multiline Input bug exists ? let us know if you need any help in understanding the working of code.

@Sumitwarrior7 gentle ping !

@Nabhag8848
Copy link
Collaborator

Hey @Sumitwarrior7 Merging as this is your first PR, We can merge it. You can keep on working on that issue. Thanks !

@Nabhag8848 Nabhag8848 merged commit 0ade592 into RocketChat:main Mar 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Selecting Same Workspace Again Gives Notification About Workspace is Changed
3 participants