[ Bug ] Removed emojis from the app #40
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,8 @@ export function getConnectPreview( | |
| : undefined; | ||
| const thumb = workspace_icon_url ? { url: workspace_icon_url } : undefined; | ||
| const title = [ | ||
| `** [**${workspace_name}**](${Notion.WEBSITE_URL})**`, | ||
| "**Connected to Workspace**", | ||
| ]; | ||
| const description = [""]; | ||
| const avatarElement = elementBuilder.addImage({ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ export function getSelectDatabaseLayout( | |
| const { workspace_icon, owner } = tokenInfo; | ||
| const { name, avatar_url } = owner.user; | ||
|
|
||
| const database_name = properties.name.replace("📚 ", ""); | ||
| const database_url = properties.link; | ||
|
|
||
| const elementBuilder = new ElementBuilder(appId); | ||
|
|
@@ -26,7 +26,7 @@ export function getSelectDatabaseLayout( | |
| : undefined; | ||
| const thumb = workspace_icon_url ? { url: workspace_icon_url } : undefined; | ||
| const title = [ | ||
| `**Database Name**`, | ||
| `[**${database_name}**](${database_url})`, | ||
| ]; | ||
| const description = [""]; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -132,7 +132,7 @@ export class NotionSDK implements INotionSDK { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| private async getPageObjectFromResults(item, emoji:boolean = false): Promise<IPage | null> { | ||||||
| const typesWithTitleProperty = [ | ||||||
| NotionObjectTypes.WORKSPACE.toString(), | ||||||
| NotionObjectTypes.PAGE_ID.toString(), | ||||||
|
|
@@ -145,7 +145,7 @@ export class NotionSDK implements INotionSDK { | |||||
| const pageName: string = | ||||||
| properties.title.title[0]?.text?.content || | ||||||
| NotionObjectTypes.UNTITLED; | ||||||
| return this.returnPage(pageName, pageId, emoji); | ||||||
| } | ||||||
|
|
||||||
| // title property either be at first or last position | ||||||
|
|
@@ -161,7 +161,7 @@ export class NotionSDK implements INotionSDK { | |||||
| const name: string = | ||||||
| properties[firstColumn].title[0]?.text?.content || | ||||||
| NotionObjectTypes.UNTITLED; | ||||||
| return this.returnPage(name, pageId, emoji); | ||||||
| } | ||||||
|
|
||||||
| //title at last position and has subpage | ||||||
|
|
@@ -172,15 +172,15 @@ export class NotionSDK implements INotionSDK { | |||||
| const name: string = | ||||||
| properties[lastColumn].title[0]?.text?.content || | ||||||
| NotionObjectTypes.UNTITLED; | ||||||
| return this.returnPage(name, pageId, emoji); | ||||||
| } | ||||||
|
|
||||||
| return null; | ||||||
| } | ||||||
|
|
||||||
| private returnPage(name: string, page_id: string, emoji: boolean=false): IPage { | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| return { | ||||||
| name: `${emoji ? "📄" : ""} ${name}`, | ||||||
| parent: { | ||||||
| type: NotionObjectTypes.PAGE_ID, | ||||||
| page_id, | ||||||
|
|
@@ -520,15 +520,16 @@ export class NotionSDK implements INotionSDK { | |||||
| const objectType: string = item?.[NotionObjectTypes.OBJECT]; | ||||||
| if (objectType.includes(NotionObjectTypes.PAGE)) { | ||||||
| const pageObject = await this.getPageObjectFromResults( | ||||||
| item, | ||||||
| true | ||||||
| ); | ||||||
|
|
||||||
| if (pageObject) { | ||||||
| result.push(pageObject); | ||||||
| } | ||||||
| } else { | ||||||
| const databaseObject = | ||||||
| await this.getDatabaseObjectFromResults(item, true); | ||||||
|
|
||||||
| result.push(databaseObject); | ||||||
| } | ||||||
|
|
@@ -540,7 +541,7 @@ export class NotionSDK implements INotionSDK { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| private async getDatabaseObjectFromResults(item, emoji:boolean = false): Promise<IDatabase> { | ||||||
| const databaseNameTitleObject = item?.[NotionObjectTypes.TITLE]; | ||||||
| const name: string = databaseNameTitleObject.length | ||||||
| ? databaseNameTitleObject[0]?.plain_text | ||||||
|
|
@@ -549,7 +550,7 @@ export class NotionSDK implements INotionSDK { | |||||
|
|
||||||
| return { | ||||||
| info: { | ||||||
| name: `${emoji ? "📚":""} ${name}`, | ||||||
| link: item?.url, | ||||||
| }, | ||||||
| parent: { | ||||||
|
|
@@ -565,8 +566,9 @@ export class NotionSDK implements INotionSDK { | |||||
| prop: IPageProperties | ||||||
| ): Promise<(INotionPage & { pageId: string }) | Error> { | ||||||
| try { | ||||||
| const { parent } = page; | ||||||
| const { title } = prop; | ||||||
| const name = page.name.replace("📄", ""); | ||||||
|
|
||||||
| const data = { | ||||||
| parent, | ||||||
|
|
@@ -597,7 +599,7 @@ export class NotionSDK implements INotionSDK { | |||||
|
|
||||||
| let result: INotionPage = { | ||||||
| link: response?.data?.url, | ||||||
| name: name, | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| title, | ||||||
| }; | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add the emojis in the documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, revert changes of docs.