chore: remove langchain _run method wrapper #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style: refactor relative imports in non __init__ files due to problematic handling in tests tests: new test for checking if BaseModel args schema annotations are equal to _run function annotations
boczekbartek
approved these changes
Jan 29, 2025
| tool_input_annotations = ( | ||
| tool.__annotations__["args_schema"].__args__[0].__annotations__ | ||
| ) | ||
| assert tool_run_annotations == tool_input_annotations |
There was a problem hiding this comment.
Will it compare types as well?
There was a problem hiding this comment.
Yes, these are dicts of {'arg_name': 'type'} e.g. {'action_name': 'str'}
maciejmajek
commented
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Removing ._run method wrapper due to lsp typing problem.- wrong type annotations were shown for ._run methods using the wrapper.
Proposed Changes
Testing