Fix BRDF initialization in rhi-null use case #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Pełka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes null pointer dereferencing that can be caused by running
-rhi=nullscenario.It was experienced here : o3de#18649 (comment).
This PR does not require fix in development, since code in
BootstrapSystemComponent.cppis heavily modified in dev comparing to 2409.1How was this PR tested?
Run game launcher with and test against issue o3de/o3de-extras#792.
-rhi=null -console-mode- starts without assertions and crashes (produce some warnings regarding ROS 2 Gem)-rhi=vulkan -console-mode- works, does not reintroduce issue