-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github Actions #2283
Update Github Actions #2283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
@@ -7,7 +7,7 @@ jobs: | |||
build-and-test: | |||
runs-on: ubuntu-latest | |||
container: | |||
image: robojackets/robocup-software:foxy | |||
image: robojackets/robocup-software:humble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we push a humble tag of this image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see that we did. it says on docker hub that I did actually, LOL. how did you guys manage that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup I made a humble tag on Sundays meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were still signed in on the shop computer so I logged in on your account
@sanatd33 you should merge this and then rebase every branch with an open PR so the new checks run |
* change to humble * change dockerfile * remvoe werror switch --------- Co-authored-by: petergarud <[email protected]>
* change to humble * change dockerfile * remvoe werror switch --------- Co-authored-by: petergarud <[email protected]>
fix github actions by changing the ros from foxy to humble