Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions #2283

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Update Github Actions #2283

merged 3 commits into from
Oct 1, 2024

Conversation

sanatd33
Copy link
Contributor

fix github actions by changing the ros from foxy to humble

@sanatd33 sanatd33 changed the title change to humble Update Github Actions Sep 29, 2024
@jacksherling jacksherling self-requested a review September 30, 2024 01:01
Copy link
Contributor

@jacksherling jacksherling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@@ -7,7 +7,7 @@ jobs:
build-and-test:
runs-on: ubuntu-latest
container:
image: robojackets/robocup-software:foxy
image: robojackets/robocup-software:humble
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we push a humble tag of this image?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see that we did. it says on docker hub that I did actually, LOL. how did you guys manage that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I made a humble tag on Sundays meeting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were still signed in on the shop computer so I logged in on your account

@sid-parikh
Copy link
Contributor

sid-parikh commented Oct 1, 2024

@sanatd33 you should merge this and then rebase every branch with an open PR so the new checks run
(or make everyone else do it of course)

@sanatd33 sanatd33 merged commit 7eef34a into ros2 Oct 1, 2024
2 checks passed
@sanatd33 sanatd33 deleted the fix-actions branch October 1, 2024 13:49
piman51277 pushed a commit that referenced this pull request Oct 6, 2024
* change to humble

* change dockerfile

* remvoe werror switch

---------

Co-authored-by: petergarud <[email protected]>
shourikb pushed a commit that referenced this pull request Oct 30, 2024
* change to humble

* change dockerfile

* remvoe werror switch

---------

Co-authored-by: petergarud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants