Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dependency on Deprecated Disutils #2281

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Remove Dependency on Deprecated Disutils #2281

merged 1 commit into from
Oct 1, 2024

Conversation

Squid5678
Copy link
Contributor

Description

This removes the dependency on deprecated disutils when sourcing.

Associated / Resolved Issue

Resolves https://app.clickup.com/t/86b26zjnt

Steps to Test

  1. source
  2. run make perf to make sure things still work

Expected result:???

Key Files to Review

Group 1

  1. source.bash
  2. source.zsh

@jacksherling jacksherling merged commit 831009d into ros2 Oct 1, 2024
1 of 2 checks passed
@jacksherling jacksherling deleted the rm-disutils branch October 1, 2024 23:18
piman51277 pushed a commit that referenced this pull request Oct 6, 2024
@Squid5678 @piman51277
Remove Dependency on Deprecated Disutils (#2281)
a994692 
updated files
shourikb pushed a commit that referenced this pull request Oct 30, 2024
@Squid5678 @shourikb
Remove Dependency on Deprecated Disutils (#2281)
5314aa9 
updated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanatd33 sanatd33 sanatd33 approved these changes

@shourikb shourikb Awaiting requested review from shourikb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Squid5678 @sanatd33 @jacksherling