Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated development dockerfile + installation docs #2278

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Conversation

rishiso
Copy link
Contributor

@rishiso rishiso commented Sep 29, 2024

Description

Added the Dockerfile used to create the Docker image for the Robocup development environment (https://hub.docker.com/r/robojackets/robocup-software-dev). Also, updated some of the installation docs.

ClickUp

Issue

@sid-parikh
Copy link
Contributor

oh can you actually leave the old dockerfile in? I believe that is the image we use for GH CI. it does need to be updated but it's good to have a non-desktop image for build-and-test

@sid-parikh
Copy link
Contributor

you can commit this one as development.Dockerfile or something similar -- maybe we can make a subdirectory. also maybe some docs? i think we actually need a docs section on installation tips, various setups we have successfully done. i'm working on a UTM guide for that

@sid-parikh
Copy link
Contributor

also, once this PR is approved, we can push this to the RoboJackets DockerHub account

@rishiso
Copy link
Contributor Author

rishiso commented Sep 29, 2024

Added some docs and will update the RoboJackets DockerHub description when I get access.

Still looking for someone to build the image on an AMD/x86 machine. Please let me know if it works.

@sid-parikh
Copy link
Contributor

Sorry, didn't manage to test it on my AMD machine at home. Will try on shop computer today.

Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@jacksherling jacksherling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rishiso rishiso changed the title Updated legacy dockerfile with new setup Updated development dockerfile + Installation Docs Jan 23, 2025
@rishiso rishiso changed the title Updated development dockerfile + Installation Docs Updated development dockerfile + installation docs Jan 23, 2025
@rishiso rishiso merged commit 07ac958 into ros2 Jan 23, 2025
2 checks passed
@rishiso rishiso deleted the docker-update branch January 23, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants