This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a brief description.
Added some images for the readme file.
Added two images for project description.
Added new images.
92b308d
to
4d6de1d
Compare
Added an additional build instruction.
andrewyarovoi
suggested changes
Jan 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this code looks good. The main thing is that there are a lot of hard coded parameters. These should be added to the pointcloud_filter.yaml file and then should be passed in to the util functions. That way, they can be tuned without requiring rebuilding the project and they can all be in one place (with comments and units).
Fixed a typo in the readme file.
…age. removed hard coded variables.
@andrewyarovoi I removed hard coded values based on your feedback. |
andrewyarovoi
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments. Everything looks good now. Great job!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This project contains a software package that segments lidar point cloud into clusters and creates a bounding box over each cluster in real time. This package adds a feature to localize objects surrounded by the robot such as barrels and people. Here is readme file for this project.
This PR does the following:
Fixes #777 and #651
Testing steps (If relevant)
Test Case 1
roslaunch igvc_perception pointcloud_filter.launch
roslaunch igvc_perception ptseg.launch
Expectation: You should see the following result in your rviz screen. Each cluster has its own bounding box.
Note: here is readme file for this project.
Self Checklist
make format