Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Javascript reference to open cloud datastore doc #916

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

SammyBear2015
Copy link

@SammyBear2015 SammyBear2015 commented Nov 17, 2024

Changes

Adds JavaScript examples to the existing markdown documentation, providing alternative code implementations alongside the original Python examples for the user inventory and leaderboard functionalities.

Update 12.19.24

Made collapsible sections for JavaScript and Python code. Python code is open by default since it's the main code on the docs.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

Added a JavaScript Examples to expand on the languages you can use open-cloud for
@SammyBear2015 SammyBear2015 requested a review from a team as a code owner November 17, 2024 00:12
@github-actions github-actions bot added the cloud label Nov 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SammyBear2015, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Nov 17, 2024
@SammyBear2015 SammyBear2015 changed the title Update usage-data-stores.md Added Javascript reference to open cloud datastore doc Nov 21, 2024
@aetter aetter requested a review from Nightriff December 19, 2024 22:56
@aetter
Copy link
Contributor

aetter commented Dec 19, 2024

Hey @SammyBear2015 thanks for the PR and patience on the long review time. We'll very likely change the formatting into tabs, like in inventory.md, but I've tagged @Nightriff here to take a look at the code -- I can worry about the formatting stuff after that.

@SammyBear2015
Copy link
Author

Sounds good

Made collapsible sections for JavaScript and Python code. Python code is open by default since it's the main code on the docs.
Copy link

github-actions bot commented Jan 3, 2025

This pull request has been inactive for 14 days. If it remains inactive for another 7 days, it will close. Please update or comment on this pull request to keep it open. 🙏

@github-actions github-actions bot added the stale label Jan 3, 2025
@SammyBear2015
Copy link
Author

No inactive

@github-actions github-actions bot removed the stale label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested This pull request has changes requested prior to merging cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants