refactor: remove types from typed properties and move types to dockblock

RobinTheHood · Nov 26, 2023 · 4c71ed4 · 4c71ed4
1 parent 412f6af
commit 4c71ed4
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 11 deletions.
diff --git a/src/Classes/Archive/Archive.php b/src/Classes/Archive/Archive.php
@@ -13,9 +13,14 @@
  */
 class Archive
 {
-    private ArchiveName $archiveName;
-    private Version $version;
-    private string $archivesRootPath;
+    /** @var ArchiveName */
+    private $archiveName;
+
+    /** @var Version */
+    private $version;
+
+    /** @var string */
+    private $archivesRootPath;
 
     public static function create(string $archiveName, string $version, string $archivesRootPath): Archive
     {

diff --git a/src/Classes/Archive/ArchiveHandler.php b/src/Classes/Archive/ArchiveHandler.php
@@ -14,10 +14,11 @@
  */
 class ArchiveHandler
 {
-    private LocalModuleLoader $localModuleLoader;
+    /** @var LocalModuleLoader */
+    private $localModuleLoader;
 
     /** @var string /.../ModifiedModuleLoaderClient/Modules */
-    private string $modulesRootPath;
+    private $modulesRootPath;
 
     public static function create(int $mode): ArchiveHandler
     {

diff --git a/src/Classes/Archive/ArchiveName.php b/src/Classes/Archive/ArchiveName.php
@@ -22,11 +22,14 @@
  */
 class ArchiveName
 {
-    private string $value;
+    /** @var string */
+    private $value;
 
-    private string $vendorName;
+    /** @var string */
+    private $vendorName;
 
-    private string $moduleName;
+    /** @var string */
+    private $moduleName;
 
     public function __construct(string $value)
     {

diff --git a/src/Classes/Archive/ArchivePuller.php b/src/Classes/Archive/ArchivePuller.php
@@ -15,9 +15,14 @@
  */
 class ArchivePuller
 {
-    private HttpRequest $httpRequest;
-    private Parser $parser;
-    private string $archivesRootPath;
+    /** @var HttpRequest */
+    private $httpRequest;
+
+    /** @var Parser */
+    private $parser;
+
+    /** @var string */
+    private $archivesRootPath;
 
     public static function create(): ArchivePuller
     {

diff --git a/src/Classes/Helpers/FileHelper.php b/src/Classes/Helpers/FileHelper.php
@@ -19,6 +19,7 @@ class FileHelper
     public const FILES_ONLY = 1;
     public const DIRS_ONLY = 2;
 
+    /** @var String[] */
     protected static $ignoreList = [
         '.DS_Store', '.git'
     ];