Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating feature for bytes #209

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Rating feature for bytes #209

merged 7 commits into from
Apr 4, 2024

Conversation

MSamiTariq
Copy link
Contributor

@MSamiTariq MSamiTariq commented Mar 28, 2024

Pull Request Template

Refers: #178

Before submitting this PR, please make sure you have completed the following checklist. This helps ensure that our codebase remains high quality and that our features work well across all supported devices and themes.

Code Review

  • I have carefully reviewed my code and believe it is final from my side.
  • I have ensured there is no hardcoded color in my changes. Colors should be defined in theme files and reused.

Theme Compatibility

  • I have tested the new feature or updates in both light and dark themes.
  • I confirm that the visual aspects of the feature are compatible and appealing in both themes.

Device Compatibility

  • I have tested my changes on mobile screen sizes.
  • I have tested my changes on tablet screen sizes.
  • I have tested my changes on laptop screen sizes.

Functional Testing

  • I have thoroughly tested the functionality of my changes.
  • I am confident that my changes do not negatively impact existing features.

Testing Documentation

Please provide a brief description of the tests you have performed to verify your changes. Include any relevant scenarios or edge cases.

Tested the ratings feature by giving the tidbits rating and verified the ratings on the /tidbits/ratings/ page.

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dodao-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 10:41am

@RobinNagpal RobinNagpal merged commit 1d37248 into main Apr 4, 2024
3 checks passed
@RobinNagpal RobinNagpal deleted the sami/byte-rating branch April 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants