Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AX-4551: Incomplete List of Disallowed Inputs in @babel/traverse #58

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

audiocipher
Copy link
Collaborator

This PR is to resolve the critical snyk vulnerability @babel/traverse Incomplete List of Disallowed Inputs.

This vulnerability was introduced through [email protected], [email protected] and resolved by upgrading to @babel/[email protected].

*Note: upgrading to @babel/[email protected] caused errors due to an incompatibility between ember-auto-import and webpack, so an additional change was made to resolve this in ember-cli-build.js.

@ross-tew-expel
Copy link
Collaborator

@audiocipher - looking good from a first pass! One thing that comes to mind:

@nabeelz7
Copy link
Contributor

nabeelz7 commented Mar 15, 2024

*Note: upgrading to @babel/[email protected] caused errors due to an incompatibility between ember-auto-import and webpack, so an additional change was made to resolve this in ember-cli-build.js.

Unfortunately due to rebuilding yarn.lock its hard to tell how many changes are being made here. Was upgrading to node 16 required because of @babel/[email protected]. What version of this package is currently there (to see if it was because of a major bump of this package) -- too lazy to check myself.

@audiocipher
Copy link
Collaborator Author

*Note: upgrading to @babel/[email protected] caused errors due to an incompatibility between ember-auto-import and webpack, so an additional change was made to resolve this in ember-cli-build.js.

Unfortunately due to rebuilding yarn.lock its hard to tell how many changes are being made here. Was upgrading to node 16 required because of @babel/[email protected]. What version of this package is currently there (to see if it was because of a major bump of this package) -- too lazy to check myself.

@nabeelz7 @ross-tew-expel
Upgrading to node 16 was required in order to fix the error webpack returned errors to ember-auto-import after bumping the direct dependency [email protected] to [email protected].

In my latest commit I tried only bumping the transitive dependency @babel/[email protected] to @babel/[email protected], but I got the same webpack error described above.

Copy link
Collaborator

@ross-tew-expel ross-tew-expel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the additional research, AJ - sounds like this is the best path forward

@audiocipher audiocipher merged commit 57e546c into main Mar 18, 2024
9 checks passed
@audiocipher audiocipher deleted the AX-4551 branch March 18, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants