This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Allow nonce owner to be null. #5
Open
+409
−2,540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return NonceEntity|null | ||
| */ | ||
| public function getUnassociated($nonce, $namespace = 'default'); |
|
Question: wouldn't it make more sense to have a "system" owner, rather than having no owner at all? |
|
That means we would have to maintain a owner, and I don't really thinks is a good idea. While I do agree a system owner would be a good thing, it's to much devops hussel to make it worth my time. |
|
@noggan fix the broken tests, update the dependencies and update the readme and ill merge it. |
|
Changes Unknown when pulling 3cde992 on noggan:master into * on Roave:master*. |
|
Changes Unknown when pulling 03228ee on noggan:master into * on Roave:master*. |
|
Changes Unknown when pulling 0570ead on noggan:master into * on Roave:master*. |
|
Changes Unknown when pulling 13a2bfa on noggan:master into * on Roave:master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow creating and consuming nonce without having an owner.