Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run containers part 2 #66

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
9b67893
WIP: Run container
josephglanville Mar 23, 2020
3124aa4
Fix some bugs in the run container implementation
Kerollmops Sep 11, 2020
2068bb6
Fix the to_array/bitmap impl for runs, the end bound is inclusive
Kerollmops Sep 11, 2020
e605f64
Rework the array bitmap intersect_with using Vec::retain
Kerollmops Sep 11, 2020
9321618
Implement the array run intersect_with operation
Kerollmops Sep 11, 2020
a62fc7d
Implement the run array intersect_with operation
Kerollmops Sep 11, 2020
d658f28
Implement the run run union_with operation
Kerollmops Sep 11, 2020
0ded028
Implement the run array union_with operation
Kerollmops Sep 12, 2020
fe8a4ab
Implement the array run union_with operation
Kerollmops Sep 12, 2020
613163f
Implement the bitmap run union_with operation
Kerollmops Sep 12, 2020
0a66483
Implement the run run intersect_with operation
Kerollmops Sep 12, 2020
9af4366
Implement the bitmap run intersect_with operation
Kerollmops Sep 12, 2020
9612ae9
Implement the run bitmap intersect_with operation
Kerollmops Sep 12, 2020
4ae8986
Simplify the run run intersect_with operation
Kerollmops Sep 12, 2020
924d4db
Implement the remove_range operation for the run store type
Kerollmops Sep 12, 2020
d7bcad3
Implement the run array and array run is_disjoint operation
Kerollmops Sep 12, 2020
cb69d80
Implement the run run is_disjoint operation
Kerollmops Sep 13, 2020
c77c0f8
Simplify the array bitmap difference_with operation
Kerollmops Sep 13, 2020
3a9eefd
Implement the array run difference_with operation
Kerollmops Sep 13, 2020
183c1bb
Implement the bitmap run difference_with operation
Kerollmops Sep 13, 2020
07d0fcc
Clippy and fmt pass
Kerollmops Sep 13, 2020
3c99804
Implement the run array difference_with operation
Kerollmops Sep 13, 2020
c762f93
Mark array run symmetric_difference_with operation as unimplemented
Kerollmops Sep 13, 2020
9744f12
Implement the array run is_subset operation
Kerollmops Sep 13, 2020
67784ad
Implement the run run difference_with operation
Kerollmops Sep 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement the run array difference_with operation
Kerollmops committed Sep 13, 2020
commit 3c99804e0758798e84a3cf2f2fdc1306b1fca542
8 changes: 6 additions & 2 deletions src/bitmap/store.rs
Original file line number Diff line number Diff line change
@@ -661,7 +661,7 @@ impl Store {
vec.retain(|i| !run.contains(*i));
}
(ref mut this @ &mut Bitmap(..), &Array(ref vec2)) => {
for index in vec2.iter() {
for index in vec2 {
this.remove(*index);
}
}
@@ -677,7 +677,11 @@ impl Store {
}
// TODO(jpg) difference_with run, *
(&mut Run(ref mut _intervals1), &Run(ref _intervals2)) => unimplemented!(),
(&mut Run(ref mut _intervals), &Array(ref _vec)) => unimplemented!(),
(ref mut this @ &mut Run(..), &Array(ref vec)) => {
for i in vec {
this.remove(*i);
}
}
(&mut Run(ref mut _vec), _store @ &Bitmap(..)) => unimplemented!(),
}
}