Fix #150

RinteRface · Sep 15, 2021 · 75a34aa · 75a34aa
1 parent 5c5d5df
commit 75a34aa
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,9 @@ Shiny 1.7.0. Thanks @wch.
 ## Minor change
 - Internal change regarding the `{waiter}` package but no user impact. Thanks @JohnCoene. 
 
+## Bug fix
+- Fix #150: Warning when using controlbarMenu. 
+
 # shinydashboardPlus 2.0.2
 
 - Simple patch to fix wrong .Rbuildignore [rule](https://github.com/DivadNojnarg/outstanding-shiny-ui/issues/52).

diff --git a/R/dashboardControlbar.R b/R/dashboardControlbar.R
@@ -223,8 +223,7 @@ controlbarMenu <- function(..., id = NULL, selected = NULL) {
     ...,
     id = id,
     selected = selected,
-    type = "tabs",
-    position = NULL
+    type = "tabs"
   )
 
   # remove parent div causing CSS margin issues

diff --git a/docs/news/index.html b/docs/news/index.html