Email::Abstract, Test::Email, and XML::Simple are all developer depen…

…dencies
RichardPooleEDB · Jun 12, 2014 · 7bf28b9 · 7bf28b9
1 parent a908c1d
commit 7bf28b9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 22 deletions.
diff --git a/t/approval/admincc.t b/t/approval/admincc.t
@@ -2,11 +2,6 @@
 use strict;
 use warnings;
 use Test::More;
-BEGIN {
-    eval { require Email::Abstract; require Test::Email; 1 }
-        or plan skip_all => 'require Email::Abstract and Test::Email';
-}
-
 
 use RT;
 use RT::Test tests => "no_declare";

diff --git a/t/approval/basic.t b/t/approval/basic.t
@@ -1,10 +1,6 @@
 use strict;
 use warnings;
 use RT::Test tests => undef;
-BEGIN {
-    plan skip_all => 'Email::Abstract and Test::Email required.'
-        unless eval { require Email::Abstract; require Test::Email; 1 };
-}
 
 use RT::Test::Email;
 

diff --git a/t/mail/html-outgoing.t b/t/mail/html-outgoing.t
@@ -1,11 +1,6 @@
 use strict;
 use warnings;
 use RT::Test tests => undef;
-BEGIN {
-    plan skip_all => 'Email::Abstract and Test::Email required.'
-        unless eval { require Email::Abstract; require Test::Email; 1 };
-    plan tests => 22;
-}
 
 use RT::Test::Email;
 use Test::Warn;
@@ -175,6 +170,7 @@ mail_ok {
     'Content-Type' => qr{multipart},
 };
 
+done_testing;
 
 sub parts_regex {
     my ($text, $html) = @_;

diff --git a/t/web/search_rss.t b/t/web/search_rss.t
@@ -39,14 +39,11 @@ my $rss_content = $agent->content;
 $agent->get_ok($rdf_path);
 is($agent->content, $rss_content, 'old Results.rdf still works');
 
-SKIP: {
-    eval { require XML::Simple; };
-    skip 'no XML::Simple found', 6 if $@;
-    my $rss = XML::Simple::XMLin( $rss_content );
-    is( scalar @{ $rss->{item} }, 5, 'item number' );
-    for ( 1 .. 5 ) {
-        is( $rss->{item}[$_-1]{title}, 'Ticket ' . $_, 'title' . $_ );
-    }
+use XML::Simple;
+my $rss = XML::Simple::XMLin( $rss_content );
+is( scalar @{ $rss->{item} }, 5, 'item number' );
+for ( 1 .. 5 ) {
+    is( $rss->{item}[$_-1]{title}, 'Ticket ' . $_, 'title' . $_ );
 }
 
 # not login at all