clear input earlier when correct to protect overflows

RevenantX · Jan 27, 2025 · 3d0ff4e · 3d0ff4e
1 parent 080ec66
commit 3d0ff4e
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/LiteEntitySystem/ServerEntityManager.cs b/LiteEntitySystem/ServerEntityManager.cs
@@ -318,7 +318,12 @@ public unsafe DeserializeResult Deserialize(NetPlayer player, ReadOnlySpan<byte>
                 bool correctInput = player.State == NetPlayerState.WaitingForFirstInput ||
                                     Utils.SequenceDiff(inputInfo.Tick, player.LastReceivedTick) > 0;
 
-                if (inData.Length == 0)
+                //remove oldest input if overflow
+                int removedTick = player.AvailableInput.Count == MaxStoredInputs && correctInput
+                    ? player.AvailableInput.ExtractMin().Tick 
+                    : -1;
+
+                if (correctInput && inData.Length == 0)
                 {
                     //empty input when no controllers
                     player.AvailableInput.Add(inputInfo, inputInfo.Tick);
@@ -350,10 +355,7 @@ public unsafe DeserializeResult Deserialize(NetPlayer player, ReadOnlySpan<byte>
                 clientTick++;
 
 
-                //remove oldest input if overflow
-                int removedTick = player.AvailableInput.Count == MaxStoredInputs 
-                    ? player.AvailableInput.ExtractMin().Tick 
-                    : -1;
+
 
                 //read input
                 foreach (var controller in GetEntities<HumanControllerLogic>())