Merge pull request #554 from psyke83/ps3_triggerfilter

Implement filterTrigger for PS3 controllers
RetroPie · Apr 9, 2019 · fd04b15 · fd04b15
2 parents 91d0b6c + 03341f2
commit fd04b15
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 0 deletions.
diff --git a/es-core/src/InputManager.cpp b/es-core/src/InputManager.cpp
@@ -172,6 +172,12 @@ void InputManager::deinit()
 }
 
 int InputManager::getNumJoysticks() { return (int)mJoysticks.size(); }
+
+int InputManager::getAxisCountByDevice(SDL_JoystickID id)
+{
+	return SDL_JoystickNumAxes(mJoysticks[id]);
+}
+
 int InputManager::getButtonCountByDevice(SDL_JoystickID id)
 {
 	if(id == DEVICE_KEYBOARD)

diff --git a/es-core/src/InputManager.h b/es-core/src/InputManager.h
@@ -48,6 +48,7 @@ class InputManager
 	void deinit();
 
 	int getNumJoysticks();
+	int getAxisCountByDevice(int deviceId);
 	int getButtonCountByDevice(int deviceId);
 	int getNumConfiguredDevices();
 

diff --git a/es-core/src/guis/GuiInputConfig.cpp b/es-core/src/guis/GuiInputConfig.cpp
@@ -133,6 +133,11 @@ GuiInputConfig::GuiInputConfig(Window* window, InputConfig* target, bool reconfi
 				return false;
 			}
 
+
+			// filter for input quirks specific to Sony DualShock 3
+			if(filterTrigger(input, config))
+				return false;
+
 			// we are configuring
 			if(input.value != 0)
 			{
@@ -331,3 +336,24 @@ void GuiInputConfig::clearAssignment(int inputId)
 {
 	mTargetConfig->unmapInput(GUI_INPUT_CONFIG_LIST[inputId].name);
 }
+
+bool GuiInputConfig::filterTrigger(Input input, InputConfig* config)
+{
+#if defined(__linux__)
+	// match PlayStation joystick with 6 axes only
+	if((strstr(config->getDeviceName().c_str(), "PLAYSTATION") != NULL \
+	  || strstr(config->getDeviceName().c_str(), "PS3 Game") != NULL \
+	  || strstr(config->getDeviceName().c_str(), "PS(R) Game") != NULL) \
+	  && InputManager::getInstance()->getAxisCountByDevice(config->getDeviceId()) == 6)
+	{
+		// digital triggers are unwanted
+		if (input.type == TYPE_BUTTON && (input.id == 6 || input.id == 7))
+			return true;
+		// ignore analog values < 0
+		if (input.type == TYPE_AXIS && (input.id == 2 || input.id == 5) && input.value < 0)
+			return true;
+	}
+#endif
+
+	return false;
+}
diff --git a/es-core/src/guis/GuiInputConfig.h b/es-core/src/guis/GuiInputConfig.h
@@ -28,6 +28,7 @@ class GuiInputConfig : public GuiComponent
 
 	bool assign(Input input, int inputId);
 	void clearAssignment(int inputId);
+	bool filterTrigger(Input input, InputConfig* config);
 
 	void rowDone();