Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always prioritize games with release date when sorting by release date #3127

Conversation

bhimbho
Copy link
Contributor

@bhimbho bhimbho commented Jan 25, 2025

No description provided.

Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jamiras
Copy link
Member

Jamiras commented Jan 25, 2025

We briefly discussed this behavior in #2706 (comment).

Jamiras:
As a player, I'd most likely look for either the oldest game on the list, or the newest, and wouldn't care at all about the ones without a date. As such, maybe it's better the way you had it.

and

wescopeland:
To be clear, I'm only seeing null dates appear at the bottom of the list if the sort is by earliest (ascending).
...
However, based on the findings reported in my previous comment, this is a behavior I'm in favor of.

Both #3116 and #2957 seem to want nulls to always be at the end, which this seems to address. I just want to make sure everyone is in favor of this change.

@wescopeland
Copy link
Member

I've grown to think the change in this PR is most likely desirable for two reasons:

  • It's one we keep hearing about on Discord and elsewhere.
  • From my own day-to-day using the site as a player, seeing null dates first in the sort order is unexpected.

On the other hand, as an achievement developer, I do want to see the null dates first when I do this particular sort.

For the achievement developer persona, we should probably handle that use case in Filament.

@bhimbho
Copy link
Contributor Author

bhimbho commented Jan 25, 2025

Does this require any further delibration?

@bhimbho bhimbho closed this Jan 25, 2025
@bhimbho bhimbho reopened this Jan 25, 2025
@wescopeland
Copy link
Member

Hey @bhimbho 👋

We'll get around to merging this before we do our next release. Thanks!

@Jamiras
Copy link
Member

Jamiras commented Jan 26, 2025

On the other hand, as an achievement developer, I do want to see the null dates first when I do this particular sort.

For the achievement developer persona, we should probably handle that use case in Filament.

I don't think that's necessary. It might even be confusing for someone who is both a player and a developer. There's a page selector. If you're actively seeking the null values, you can just jump to the last page.

@wescopeland wescopeland changed the title fix: prioritize games with release date fix: always prioritize games with release date when sorting by release date Jan 26, 2025
@wescopeland wescopeland merged commit 6314e57 into RetroAchievements:master Jan 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants