-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always prioritize games with release date when sorting by release date #3127
fix: always prioritize games with release date when sorting by release date #3127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Wes Copeland <[email protected]>
We briefly discussed this behavior in #2706 (comment).
and
Both #3116 and #2957 seem to want nulls to always be at the end, which this seems to address. I just want to make sure everyone is in favor of this change. |
I've grown to think the change in this PR is most likely desirable for two reasons:
On the other hand, as an achievement developer, I do want to see the null dates first when I do this particular sort. For the achievement developer persona, we should probably handle that use case in Filament. |
Does this require any further delibration? |
Hey @bhimbho 👋 We'll get around to merging this before we do our next release. Thanks! |
I don't think that's necessary. It might even be confusing for someone who is both a player and a developer. There's a page selector. If you're actively seeking the null values, you can just jump to the last page. |
No description provided.