Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide future event achievement selection #3085

Merged

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jan 20, 2025

Allows event managers to assign an achievement prior to it becoming active without exposing it to players until it does become active.

https://discord.com/channels/310192285306454017/1328443350889795635/1330687821429608500

If an event achievement is associated to a source achievement, it's title and description and image will be obscured on the event page and achievement page.

image
image

There are still ways to get to the unobscured data, but this should be sufficient for the largest portion of the playerbase.

@wescopeland
Copy link
Member

https://discord.com/channels/310192285306454017/1328443350889795635/1330694768044277783

I could be missing something, but I think it would make more sense to consistently show "Week N" for all future achievements, regardless of whether an underlying achievement has been selected internally or not.

The internal state (whether the events team has picked an achievement) seems like it shouldn't affect what end-users see before the go-live date. Using "?????" could be confusing for users who might not know if it's intentional, a bug, or something else.

From a user's perspective, this has the benefit of all future weeks looking consistent until the go-live date has been reached.

@Jamiras
Copy link
Member Author

Jamiras commented Jan 20, 2025

"Week N" is just the placeholder prepopulated by the ra:platform:event:create-aotw command. When an actual achievement is selected, it's properties get copied to the event achievement, overwriting the "Week N"

@wescopeland
Copy link
Member

I see. It's actually a pretty good placeholder, to be honest.

I've verified the change locally, but my reservations about the "?????" label still give me pause. This could be too ambiguous. How about any of these alternatives?:

  • Coming Soon
  • Future Challenge
  • Future Achievement
  • Upcoming Challenge

@Jamiras
Copy link
Member Author

Jamiras commented Jan 20, 2025

Changed Title to "Upcoming Challenge" per popular vote: https://discord.com/channels/310192285306454017/1328443350889795635/1330716794255839262
Left Description as "?????"

@Jamiras Jamiras merged commit a63e64f into RetroAchievements:master Jan 20, 2025
8 checks passed
@Jamiras Jamiras deleted the feature/hidden_event_achievement branch January 20, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants