use 'Upcoming Challenge' for obscured title

RetroAchievements · Jan 20, 2025 · 9fe0156 · 9fe0156
1 parent 24b5e98
commit 9fe0156
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/Support/Shortcode/Shortcode.php b/app/Support/Shortcode/Shortcode.php
@@ -345,9 +345,9 @@ private function embedAchievement(int $id): string
 
         if ($data['ConsoleID'] === System::Events) {
             $achievement = Achievement::find($id);
-            if ($achievement->eventData?->source_achievement_id &&
-                $achievement->eventData?->active_from > Carbon::now()) {
-                $data['Title'] = $data['AchievementTitle'] = '?????';
+            if ($achievement->eventData?->source_achievement_id
+                && $achievement->eventData->active_from > Carbon::now()) {
+                $data['Title'] = $data['AchievementTitle'] = 'Upcoming Challenge';
                 $data['Description'] = '?????';
                 $data['BadgeName'] = '00000';
             }

diff --git a/resources/views/components/game/achievements-list/achievements-list-item.blade.php b/resources/views/components/game/achievements-list/achievements-list-item.blade.php
@@ -47,7 +47,7 @@
     } elseif ($achievement['SourceAchievementId']) {
         // future event has been picked. don't show it until it's active
         $achBadgeName = '00000';
-        $achievement['Title'] = '?????';
+        $achievement['Title'] = 'Upcoming Challenge';
         $achievement['Description'] = '?????';
         $achievement['SourceGameId'] = null;
     }

diff --git a/resources/views/pages-legacy/achievementInfo.blade.php b/resources/views/pages-legacy/achievementInfo.blade.php
@@ -138,7 +138,7 @@
             // future event has been picked. don't show it until it's active
             $eventAchievement = null;
             $badgeName = $dataOut['BadgeName'] = '00000';
-            $achievementTitleRaw = $achievementTitle = $dataOut['Title'] = '?????';
+            $achievementTitleRaw = $achievementTitle = $dataOut['Title'] = 'Upcoming Challenge';
             $achievementDescriptionRaw = $dataOut['Description'] = '?????';
             $dataOut['SourceGameId'] = null;
         } else {