Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTE Location Services: SLh and SLg interfaces implementation #48

Closed
wants to merge 48 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
6043c3e
Added SLg and SLh AVP codes.
Jun 14, 2016
928a8f2
SLg and SLh AVP's definitions add to Avp.java. Issues #37 and #38. PR…
Sep 29, 2016
8b23389
Testsuite resources configuration files for SLh and SLg. Issues #37 a…
Oct 1, 2016
a81bfbf
Testsuite remaining classes. Fixed some issues in already commited (i…
Oct 1, 2016
ccb845b
Provided methods including all AVPs for LCSRoutingInfo (RIR/RIA) and …
Oct 3, 2016
08f125c
Provided methods including all AVPs for LocationReportRequest/Answer …
Oct 4, 2016
56a87f0
Fixed all checkstyle issues. Issues #37 and #38. PR #48
Oct 4, 2016
e77cb9b
Fixed grouped AVPs for SLh RIR/RIA implementation and added 3GPP-AAA-…
Oct 6, 2016
b92434e
Fixed grouped AVPs for SLg PLR/PLA and LRR/LRA implementation .Issues…
Oct 7, 2016
68d56d1
Several fixes in testsuite client/server/session classes (including c…
Oct 7, 2016
22e07fc
Testsuite addition of attributes and methods including all AVPs for S…
Oct 8, 2016
eb3963c
Testsuite addition of attributes and methods including all AVPs for S…
Oct 9, 2016
c5187a5
Some fixes (for grouped AVPs) and additions like PLMN-List AVP both i…
Oct 9, 2016
d17cc62
Testsuite compiling error fixed. Issues #37 and #38. PR #48
Oct 9, 2016
781cb98
Added incomplete AVP definitions post 1st testsuite run. Issues #37 a…
Oct 9, 2016
238ff4a
Fixed configuration indentation and inconsistency between dictionary …
Oct 9, 2016
1470901
Multiple configuration fixes according to review of 3GPP specs after …
Oct 10, 2016
101cb26
Some minor configuration fixes as for Junit tests, vendor was imprope…
Oct 11, 2016
e561f76
Fixed application Id for SLh Junit tests to work properly. Issues #37…
Oct 12, 2016
41720db
Fixed missing inheritance in ISLgSessionFactory and some configuratio…
Oct 13, 2016
5bc102f
Added all possible available AVPs in dictionary's command definition …
Oct 13, 2016
df8e8c9
Added LocationReportRequest/Answer methods to SLg testsuite. Issues #…
Oct 14, 2016
92464e6
Enhanced SLh testsuite AVP definitions in terms of vendor id and flag…
Oct 14, 2016
b52e469
Enhanced SLg testsuite AVP definitions in terms of vendor id and flag…
Oct 14, 2016
ce088d8
Fixed wrong assignation of horizontal instead of vertical accuracy AV…
Oct 15, 2016
ea4ae7d
Some minor format/style fixes and discarded a misplaced comment. Issu…
Oct 15, 2016
743cfc5
Fixed issues with PLR AVPs Privacy-Check, PLR-Flags and Velocity-Requ…
Oct 15, 2016
9b38792
Several fixes and revamp of testsuite for SLg. PLR/PLA Junit tests pa…
Oct 16, 2016
67966a2
doLocationReportRequestEvent was inconsistently defined in the abstra…
Oct 16, 2016
54f4bab
Mainly removed misplaced/unused methods/comments in committed testsui…
Oct 17, 2016
f114228
Just added comments referencing IETF RFC 6848 in civic address testsu…
Oct 17, 2016
fd1887f
Some minor enhancements. Issues #37 and #38. PR #48
Oct 20, 2016
db366ad
LocationReportRequest case was missing in SLg Server Session Implemen…
Oct 21, 2016
d92b5e3
Some minor further enhancements, removed unneeded comments, named som…
Oct 21, 2016
1fc0984
Very minor final issues: fixed a comment and removed an unused import…
Oct 21, 2016
dd2aa68
Location-Estimate AVP to OctetString. Issues #37, #38 and #62. PR #48
Oct 21, 2016
8b8bb71
Format style improvements: changed @author presentation to the standa…
Nov 6, 2016
aacbc8f
Same as previous for remaining classes where @author format and comme…
Nov 6, 2016
1cfd048
Just placed the appropriate updated copyright comments.
Nov 6, 2016
02905b8
One commented @param was still improperly named. Issues #37, #38 and …
Nov 6, 2016
90c6b36
Comment fix for @param clientSessionListener
Nov 6, 2016
c859304
Minor style enhancements and string names for OctetString values conv…
Nov 6, 2016
3fcd971
Merge branch 'LTE_LCS' of https://github.com/RestComm/jdiameter into …
Nov 6, 2016
8f5df1e
Final minor code style final enhancements. Issues #37 and #38. PR #48
Nov 6, 2016
ae9fbfd
Enhanced values set in testsuite for obtaining cleaner Diameter trace…
Dec 8, 2016
7e50508
Final values settings in testsuite for complete perfect Diameter trac…
Dec 8, 2016
c6b33bf
Set LCS-Priority as Unsigned32 for testsuite Junit tests. Issues #37 …
Dec 20, 2016
b6022a0
Resolve conflicts introduced in dictionary recently, caused to many c…
May 16, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
# Maven #
#########
target
\$\{env.JBOSS_HOME\}

# OS generated files #
######################
Expand Down
4 changes: 0 additions & 4 deletions .travis.yml

This file was deleted.

19 changes: 1 addition & 18 deletions core/jdiameter-ha/api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
</dependency>

<!-- clustering deps -->
<!-- JBoss 5: JBoss Cache -->
<!--
<dependency>
<groupId>org.jboss.cache</groupId>
<artifactId>jbosscache-core</artifactId>
Expand All @@ -32,24 +30,9 @@
<groupId>org.jboss.cluster</groupId>
<artifactId>jboss-ha-server-cache-jbc</artifactId>
</dependency>
-->

<!-- WildFly: Infinispan Cache -->
<!--
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-core</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-tree</artifactId>
<scope>provided</scope>
</dependency>
-->

<dependency>
<groupId>org.restcomm.cluster</groupId>
<groupId>org.mobicents.cluster</groupId>
<artifactId>timers</artifactId>
</dependency>
</dependencies>
Expand Down
25 changes: 9 additions & 16 deletions core/jdiameter-ha/impl/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,33 +25,26 @@
<artifactId>jdiameter-impl</artifactId>
</dependency>

<!-- javax.transaction dependency -->
<!-- works for JBoss 5.1 -->
<!-- cache -->
<dependency>
<groupId>org.jboss.cluster</groupId>
<artifactId>jboss-ha-server-cache-jbc</artifactId>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging-log4j</artifactId>
<scope>provided</scope>
</dependency>

<!--
<!-- clustering deps -->
<dependency>
<groupId>javax</groupId>
<artifactId>javaee-api</artifactId>
<version>6.0</version>
</dependency>
-->

<dependency>
<groupId>org.restcomm.cluster</groupId>
<artifactId>core</artifactId>
<groupId>org.jboss.cluster</groupId>
<artifactId>jboss-ha-server-cache-jbc</artifactId>
</dependency>

<dependency>
<groupId>org.restcomm.cluster</groupId>
<groupId>org.mobicents.cluster</groupId>
<artifactId>cache</artifactId>
</dependency>

<dependency>
<groupId>org.restcomm.cluster</groupId>
<groupId>org.mobicents.cluster</groupId>
<artifactId>timers</artifactId>
</dependency>
</dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
import java.io.Serializable;
import java.nio.ByteBuffer;

import org.restcomm.cache.FqnWrapper;
import org.jboss.cache.Fqn;
import org.jdiameter.api.AvpDataException;
import org.jdiameter.api.Request;
import org.jdiameter.api.acc.ClientAccSession;
Expand All @@ -55,7 +55,7 @@
import org.jdiameter.client.api.parser.ParseException;
import org.jdiameter.client.impl.app.acc.IClientAccSessionData;
import org.jdiameter.common.api.app.acc.ClientAccSessionState;
import org.restcomm.cluster.MobicentsCluster;
import org.mobicents.cluster.MobicentsCluster;
import org.mobicents.diameter.impl.ha.common.AppSessionDataReplicatedImpl;
import org.mobicents.diameter.impl.ha.data.ReplicatedSessionDatasource;
import org.slf4j.Logger;
Expand All @@ -79,12 +79,12 @@ public class ClientAccSessionDataReplicatedImpl extends AppSessionDataReplicated
private IMessageParser messageParser;

/**
* @param nodeFqnWrapper
* @param nodeFqn
* @param mobicentsCluster
* @param container
* @param iface
*/
public ClientAccSessionDataReplicatedImpl(FqnWrapper nodeFqnWrapper, MobicentsCluster mobicentsCluster, IContainer container) {
super(nodeFqnWrapper, mobicentsCluster);
public ClientAccSessionDataReplicatedImpl(Fqn<?> nodeFqn, MobicentsCluster mobicentsCluster, IContainer container) {
super(nodeFqn, mobicentsCluster);

if (super.create()) {
setAppSessionIface(this, ClientAccSession.class);
Expand All @@ -97,13 +97,10 @@ public ClientAccSessionDataReplicatedImpl(FqnWrapper nodeFqnWrapper, MobicentsCl
/**
* @param sessionId
* @param mobicentsCluster
* @param container
* @param iface
*/
public ClientAccSessionDataReplicatedImpl(String sessionId, MobicentsCluster mobicentsCluster, IContainer container) {
this(
FqnWrapper.fromRelativeElementsWrapper(ReplicatedSessionDatasource.SESSIONS_FQN, sessionId),
mobicentsCluster, container
);
this(Fqn.fromRelativeElements(ReplicatedSessionDatasource.SESSIONS_FQN, sessionId), mobicentsCluster, container);
}

/*
Expand All @@ -115,7 +112,7 @@ public ClientAccSessionDataReplicatedImpl(String sessionId, MobicentsCluster mob
@Override
public void setClientAccSessionState(ClientAccSessionState state) {
if (exists()) {
putNodeValue(STATE, state);
getNode().put(STATE, state);
}
else {
throw new IllegalStateException();
Expand All @@ -130,7 +127,7 @@ public void setClientAccSessionState(ClientAccSessionState state) {
@Override
public ClientAccSessionState getClientAccSessionState() {
if (exists()) {
return (ClientAccSessionState) getNodeValue(STATE);
return (ClientAccSessionState) getNode().get(STATE);
}
else {
throw new IllegalStateException();
Expand All @@ -145,7 +142,7 @@ public ClientAccSessionState getClientAccSessionState() {
@Override
public void setInterimTimerId(Serializable tid) {
if (exists()) {
putNodeValue(INTERIM_TIMERID, tid);
getNode().put(INTERIM_TIMERID, tid);
}
else {
throw new IllegalStateException();
Expand All @@ -160,7 +157,7 @@ public void setInterimTimerId(Serializable tid) {
@Override
public Serializable getInterimTimerId() {
if (exists()) {
return (Serializable) getNodeValue(INTERIM_TIMERID);
return (Serializable) getNode().get(INTERIM_TIMERID);
}
else {
throw new IllegalStateException();
Expand All @@ -175,7 +172,7 @@ public Serializable getInterimTimerId() {
@Override
public void setDestinationHost(String destHost) {
if (exists()) {
putNodeValue(DEST_HOST, destHost);
getNode().put(DEST_HOST, destHost);
}
else {
throw new IllegalStateException();
Expand All @@ -190,7 +187,7 @@ public void setDestinationHost(String destHost) {
@Override
public String getDestinationHost() {
if (exists()) {
return (String) getNodeValue(DEST_HOST);
return (String) getNode().get(DEST_HOST);
}
else {
throw new IllegalStateException();
Expand All @@ -205,7 +202,7 @@ public String getDestinationHost() {
@Override
public void setDestinationRealm(String destRealm) {
if (exists()) {
putNodeValue(DEST_REALM, destRealm);
getNode().put(DEST_REALM, destRealm);
}
else {
throw new IllegalStateException();
Expand All @@ -220,7 +217,7 @@ public void setDestinationRealm(String destRealm) {
@Override
public String getDestinationRealm() {
if (exists()) {
return (String) getNodeValue(DEST_REALM);
return (String) getNode().get(DEST_REALM);
}
else {
throw new IllegalStateException();
Expand All @@ -229,7 +226,7 @@ public String getDestinationRealm() {

@Override
public Request getBuffer() {
byte[] data = (byte[]) getNodeValue(BUFFER);
byte[] data = (byte[]) getNode().get(BUFFER);
if (data != null) {
try {
return this.messageParser.createMessage(ByteBuffer.wrap(data));
Expand All @@ -249,14 +246,14 @@ public void setBuffer(Request buffer) {
if (buffer != null) {
try {
byte[] data = this.messageParser.encodeMessage((IMessage) buffer).array();
putNodeValue(BUFFER, data);
getNode().put(BUFFER, data);
}
catch (ParseException e) {
logger.error("Unable to encode message to buffer.");
}
}
else {
removeNodeValue(BUFFER);
getNode().remove(BUFFER);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@

import java.io.Serializable;

import org.restcomm.cache.FqnWrapper;
import org.jboss.cache.Fqn;
import org.jdiameter.api.auth.ClientAuthSession;
import org.jdiameter.client.impl.app.auth.IClientAuthSessionData;
import org.jdiameter.common.api.app.auth.ClientAuthSessionState;
import org.restcomm.cluster.MobicentsCluster;
import org.mobicents.cluster.MobicentsCluster;
import org.mobicents.diameter.impl.ha.common.AppSessionDataReplicatedImpl;
import org.mobicents.diameter.impl.ha.data.ReplicatedSessionDatasource;

Expand All @@ -66,11 +66,12 @@ public class ClientAuthSessionDataReplicatedImpl extends AppSessionDataReplicate
private static final String TS_TIMERID = "TS_TIMERID";

/**
* @param nodeFqnWrapper
* @param nodeFqn
* @param mobicentsCluster
* @param iface
*/
public ClientAuthSessionDataReplicatedImpl(FqnWrapper nodeFqnWrapper, MobicentsCluster mobicentsCluster) {
super(nodeFqnWrapper, mobicentsCluster);
public ClientAuthSessionDataReplicatedImpl(Fqn<?> nodeFqn, MobicentsCluster mobicentsCluster) {
super(nodeFqn, mobicentsCluster);

if (super.create()) {
setAppSessionIface(this, ClientAuthSession.class);
Expand All @@ -81,12 +82,10 @@ public ClientAuthSessionDataReplicatedImpl(FqnWrapper nodeFqnWrapper, MobicentsC
/**
* @param sessionId
* @param mobicentsCluster
* @param iface
*/
public ClientAuthSessionDataReplicatedImpl(String sessionId, MobicentsCluster mobicentsCluster) {
this(
FqnWrapper.fromRelativeElementsWrapper(ReplicatedSessionDatasource.SESSIONS_FQN, sessionId),
mobicentsCluster
);
this(Fqn.fromRelativeElements(ReplicatedSessionDatasource.SESSIONS_FQN, sessionId), mobicentsCluster);
}

/*
Expand All @@ -98,7 +97,7 @@ public ClientAuthSessionDataReplicatedImpl(String sessionId, MobicentsCluster mo
@Override
public void setClientAuthSessionState(ClientAuthSessionState state) {
if (exists()) {
putNodeValue(STATE, state);
getNode().put(STATE, state);
}
else {
throw new IllegalStateException();
Expand All @@ -113,7 +112,7 @@ public void setClientAuthSessionState(ClientAuthSessionState state) {
@Override
public ClientAuthSessionState getClientAuthSessionState() {
if (exists()) {
return (ClientAuthSessionState) getNodeValue(STATE);
return (ClientAuthSessionState) getNode().get(STATE);
}
else {
throw new IllegalStateException();
Expand All @@ -128,7 +127,7 @@ public ClientAuthSessionState getClientAuthSessionState() {
@Override
public boolean isStateless() {
if (exists()) {
return toPrimitive((Boolean) getNodeValue(STATELESS), true);
return toPrimitive((Boolean) getNode().get(STATELESS), true);
}
else {
throw new IllegalStateException();
Expand All @@ -143,7 +142,7 @@ public boolean isStateless() {
@Override
public void setStateless(boolean b) {
if (exists()) {
putNodeValue(STATELESS, b);
getNode().put(STATELESS, b);
}
else {
throw new IllegalStateException();
Expand All @@ -159,7 +158,7 @@ public void setStateless(boolean b) {
@Override
public String getDestinationHost() {
if (exists()) {
return (String) getNodeValue(DESTINATION_HOST);
return (String) getNode().get(DESTINATION_HOST);
}
else {
throw new IllegalStateException();
Expand All @@ -174,7 +173,7 @@ public String getDestinationHost() {
@Override
public void setDestinationHost(String host) {
if (exists()) {
putNodeValue(DESTINATION_HOST, host);
getNode().put(DESTINATION_HOST, host);
}
else {
throw new IllegalStateException();
Expand All @@ -189,7 +188,7 @@ public void setDestinationHost(String host) {
@Override
public String getDestinationRealm() {
if (exists()) {
return (String) getNodeValue(DESTINATION_REALM);
return (String) getNode().get(DESTINATION_REALM);
}
else {
throw new IllegalStateException();
Expand All @@ -204,7 +203,7 @@ public String getDestinationRealm() {
@Override
public void setDestinationRealm(String realm) {
if (exists()) {
putNodeValue(DESTINATION_REALM, realm);
getNode().put(DESTINATION_REALM, realm);
}
else {
throw new IllegalStateException();
Expand All @@ -219,7 +218,7 @@ public void setDestinationRealm(String realm) {
@Override
public Serializable getTsTimerId() {
if (exists()) {
return (Serializable) getNodeValue(TS_TIMERID);
return (Serializable) getNode().get(TS_TIMERID);
}
else {
throw new IllegalStateException();
Expand All @@ -234,7 +233,7 @@ public Serializable getTsTimerId() {
@Override
public void setTsTimerId(Serializable tid) {
if (exists()) {
putNodeValue(TS_TIMERID, tid);
getNode().put(TS_TIMERID, tid);
}
else {
throw new IllegalStateException();
Expand Down
Loading