Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton loading #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shubhagarwal1
Copy link
Contributor

#305

Doen_navorsing_oor_Nexas.mp4

I have done network throtling so that is the reason it is coming slow, to show how it looks.
Hey @Harshdev098 please review my PR

@Harshdev098
Copy link
Member

@shubhagarwal1

  • This branch has conflicts, resolve them
  • The cursor animation is not working because of changes

@shubhagarwal1
Copy link
Contributor Author

@shubhagarwal1

  • This branch has conflicts, resolve them
  • The cursor animation is not working because of changes

looking for changes

@Harshdev098
Copy link
Member

Harshdev098 commented Oct 26, 2024

@shubhagarwal1 It still persists

@shubhagarwal1
Copy link
Contributor Author

@shubhagarwal1 It still persists

Hey @Harshdev098 can we once please connect on discord

@Harshdev098
Copy link
Member

sync your fork also update your clone with latest changes of the main branch and commit your changes

@Harshdev098
Copy link
Member

We can connect on linkedin

@shubhagarwal1
Copy link
Contributor Author

Hey @Harshdev098 have solved the conflicts, please review

Copy link
Member

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just focus on adding skeleton because of your changes the cursor effect is not working
don't make much longer changes in the index.html just add the skeleton loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants