-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tree, tree-select, combo-box): apply filter when it's updated #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying refinitiv-ui with
|
Latest commit: |
2f23ef2
|
Status: | ✅ Deploy successful! |
Preview URL: | https://361bf466.refinitiv-ui.pages.dev |
Branch Preview URL: | https://fix-refresh-filter-update-v6.refinitiv-ui.pages.dev |
Size Change: +41 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
Overlay position target is failing on Linux Chrome 128 only. The issue is not reproducible on macOS or Windows. Let's wait for Chrome 129 release next week. If the test still fails, it's time for investigation. |
Theeraphat-Sorasetsakul
approved these changes
Sep 19, 2024
Theeraphat-Sorasetsakul
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tree, Tree Select & Combo Box should apply the new
filter
when it's updated. This PR fixes this issue by tapping intoupdate()
&willUpdate()
life cycle of respective components.Fixes # https://jira.refinitiv.com/browse/DME-28738
Checklist