fix(interactive-chart): hide tradingview default attribution logo (#1253

) * fix(interactive-chart): hide tradingview default attribution logo * fix(interactive-chart): hide tradingview default attribution logo * Update packages/elements/src/interactive-chart/index.ts Co-authored-by: wattachai <[email protected]> * fix(interactive-chart): hide tradingview default attribution logo * fix(interactive-chart): hide tradingview default attribution logo --------- Co-authored-by: wattachai <[email protected]> Co-authored-by: Napat Bualoy <[email protected]>
Refinitiv · Jan 24, 2025 · e273d9e · e273d9e
1 parent 8b91315
commit e273d9e
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/elements/package.json b/packages/elements/package.json
@@ -466,7 +466,7 @@
     "d3-interpolate": "^3.0.1",
     "date-fns": "^2.29.3",
     "escape-string-regexp": "^5.0.0",
-    "lightweight-charts": "^4.1.0",
+    "lightweight-charts": "^4.2.0",
     "tslib": "^2.3.1"
   },
   "devDependencies": {

diff --git a/...ages/elements/src/interactive-chart/__test__/__snapshots__/interactive-chart.test.snap.js b/...ages/elements/src/interactive-chart/__test__/__snapshots__/interactive-chart.test.snap.js
@@ -10,12 +10,13 @@ snapshots["interactive-chart/InteractiveChart Default DOM structure is correct"]
   <div part="jump-button">
   </div>
 </div>
-<div
+<a
+  href="https://www.tradingview.com"
   part="branding-container"
-  title=""
-  tooltip="Powered by Trading View"
+  target="_blank"
+  title="Charting by Trading View"
 >
-</div>
+</a>
 <div part="chart">
 </div>
 `;

diff --git a/packages/elements/src/interactive-chart/index.ts b/packages/elements/src/interactive-chart/index.ts
@@ -588,7 +588,8 @@ export class InteractiveChart extends ResponsiveElement {
             color: this.theme.backgroundColor
           },
           textColor: this.theme.textColor,
-          fontFamily: defaultFontFamily
+          fontFamily: defaultFontFamily,
+          attributionLogo: false
         },
         leftPriceScale: {
           borderColor: this.theme.scalePriceBorderColor
@@ -1183,15 +1184,20 @@ export class InteractiveChart extends ResponsiveElement {
       <div part="jump-button-container">
         <div part="jump-button"></div>
       </div>
-      <div part="branding-container" title="" tooltip="Powered by Trading View">
+      <a
+        href="https://www.tradingview.com"
+        part="branding-container"
+        title="Charting by Trading View"
+        target="_blank"
+      >
         <svg width="33" height="19" viewBox="0 0 611 314" part="branding">
           <path
             fill-rule="evenodd"
             clip-rule="evenodd"
             d="M341 124C375.242 124 403 96.2417 403 62C403 27.7583 375.242 0 341 0C306.758 0 279 27.7583 279 62C279 96.2417 306.758 124 341 124ZM481 314H337L467 4H611L481 314ZM124 4H248V128V314H124V128H0V4H124Z"
           />
         </svg>
-      </div>
+      </a>
       <div part="chart"></div>
     `;
   }

diff --git a/packages/theme-compiler/package.json b/packages/theme-compiler/package.json
@@ -30,7 +30,7 @@
     "fs-extra": "^8.1.0",
     "glob": "^10.3.9",
     "htmlparser2": "^4.0.0",
-    "less": "^4.2.0",
+    "less": "^4.2.1",
     "less-plugin-npm-import": "^2.1.0",
     "postcss": "^8.4.49",
     "svgo": "^3.2.0",