Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Minor fix to code sample from website feedback #1359

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

lornajane
Copy link
Contributor

What/Why/How?

We got a feedback item about an incorrectly named import in a code sample. This fixes it.

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@lornajane lornajane requested a review from a team as a code owner December 14, 2023 11:45
Copy link

changeset-bot bot commented Dec 14, 2023

⚠️ No Changeset found

Latest commit: bf0f874

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.033 ± 0.015 1.009 1.056 1.01 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.026 ± 0.024 0.998 1.083 1.00

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.19% 4073/5346
🟡 Branches 66.07% 2169/3283
🟡 Functions 68.43% 661/966
🟡 Lines 76.38% 3820/5001

Test suite run success

652 tests passing in 94 suites.

Report generated by 🧪jest coverage report action from bf0f874

@lornajane lornajane merged commit 513a6a1 into main Dec 14, 2023
30 checks passed
@lornajane lornajane deleted the fix-custom-rule-sample branch December 14, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants